airship/airshipctl
Code Issues Proposed changes

Remove debug field from AirshipCTLSettings

Browse Source 
As part of config refactoring process, we should remove debug field
from AirshipCTLSettings structure since debug variable is stored in
log module.

Change-Id: I02f3c7160ed0301605de32e0d0267be8524ccc12
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
Relates-To: #327
This commit is contained in:
Ruslan Aliev
2020-08-25 18:06:26 -05:00
parent f1b606f8bf
commit 4c0d2c0b57
10 changed files with 22 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/bootstrap/isogen/command_test.go
View File

@@ -234,7 +234,6 @@ func TestVerifyInputs(t *testing.T) {
func TestGenerateBootstrapIso(t *testing.T) {
t.Run("EnsureCompleteError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},
@@ -248,7 +247,6 @@ func TestGenerateBootstrapIso(t *testing.T) {
t.Run("ContextEntryPointError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},
@@ -262,7 +260,6 @@ func TestGenerateBootstrapIso(t *testing.T) {
t.Run("NewBundleByPathError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},
@@ -276,7 +273,6 @@ func TestGenerateBootstrapIso(t *testing.T) {
t.Run("SelectOneError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},
@@ -291,7 +287,6 @@ func TestGenerateBootstrapIso(t *testing.T) {
t.Run("ToObjectError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},
@@ -305,7 +300,6 @@ func TestGenerateBootstrapIso(t *testing.T) {
t.Run("verifyInputsError", func(t *testing.T) {
settings := &environment.AirshipCTLSettings{
Debug: false,
AirshipConfigPath: "testdata/config/config",
KubeConfigPath: "testdata/config/kubeconfig",
Config: &config.Config{},