airship
/
airshipctl
Code Issues Proposed changes

airship-in-a-pod: set libvirt tty=false 

This sets the airship-in-a-pod libvirt container to have `tty: false`.
With `tty: true`, the libvirt container would fail with the following
error in some environments (mostly baremetal, but VMs as well):

Error: failed to create containerd task: failed to create shim:
OCI runtime create failed: container_linux.go:380: starting container
process caused: process_linux.go:545: container init caused:
setctty: operation not permitted: unknown

The RC for the error is unknown, but `tty: true` appears to be a leftover
debugging tool, so this change disables it by default.

Change-Id: I427bd1bdbe86c8a742b871c4f8fc18e4be58660b
Closes: #578
This commit is contained in:
Matt McEuen 2021-06-11 17:26:36 -05:00
parent 77f0b32e5a
commit 4e2f772f0d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/airship-in-a-pod/airship-in-a-pod.yaml
View File

@ -21,7 +21,8 @@ spec:
- name: libvirt - name: libvirt
image: ianhowell/libvirt:latest image: ianhowell/libvirt:latest
tty: true # Set to true for debugging
tty: false
securityContext: securityContext:
privileged: true privileged: true
#SYS_ADMIN required for systemd, need to work out reqs for libvirt #SYS_ADMIN required for systemd, need to work out reqs for libvirt