airship/airshipctl
Code Issues Proposed changes

[#86] remove unused code

Browse Source 
A number of items were identified by GoLand's code inspection as
being unused.  These are being removed in this change.

Change-Id: I0c8c0b5f5c33f2e715f991a02ddd63174758c533
Signed-off-by: Alexander Hughes <Alexander.Hughes@pm.me>
This commit is contained in:
Alexander Hughes
2020-03-05 11:39:13 -05:00
parent 26fdd05b0f
commit 7549fdbeb0
21 changed files with 57 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testutil/k8sutils/mock_kubectl_factory.go
View File

@@ -49,7 +49,7 @@ func (f *MockKubectlFactory) ToDiscoveryClient() (discovery.CachedDiscoveryInter
}
func (f *MockKubectlFactory) DynamicClient() (dynamic.Interface, error) { return f.MockDynamicClient() }
func (f *MockKubectlFactory) OpenAPISchema() (openapi.Resources, error) { return f.MockOpenAPISchema() }
func (f *MockKubectlFactory) Validator(validate bool) (validation.Schema, error) {
func (f *MockKubectlFactory) Validator(bool) (validation.Schema, error) {
return f.MockValidator()
}
func (f *MockKubectlFactory) ToRESTMapper() (meta.RESTMapper, error) { return f.MockToRESTMapper() }

14
testutil/utilities.go
View File

@@ -63,20 +63,6 @@ func RunTest(t *testing.T, test *CmdTest) {
}
}
// ReadFixtureBytes is a convenience function for opening a test fixture
func ReadFixtureBytes(t *testing.T, filename string) []byte {
t.Helper()
fixtureData, err := ioutil.ReadFile(filename)
require.NoErrorf(t, err, "Unexpected error while reading fixture at %s", filename)
return fixtureData
}
// ReadFixtureString is a convenience function for opening a test fixture
func ReadFixtureString(t *testing.T, filename string) string {
t.Helper()
return string(ReadFixtureBytes(t, filename))
}
func updateGolden(t *testing.T, test *CmdTest, actual []byte) {
t.Helper()
goldenDir := filepath.Join(testdataDir, t.Name()+goldenDirSuffix)