From 241714d042ed13b366a8d350e83b3e50e872fea2 Mon Sep 17 00:00:00 2001 From: bijayasharma Date: Fri, 24 Jul 2020 14:19:57 -0400 Subject: [PATCH] [#308] Removed code style issue on Error string * This commit will remove code style issue on Error string Change-Id: Ib2344de75768362a88c077354193878366ce4b0c --- cmd/config/get_manifest_test.go | 2 +- pkg/bootstrap/isogen/command_test.go | 2 +- pkg/config/options.go | 2 +- pkg/k8s/utils/utils_test.go | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cmd/config/get_manifest_test.go b/cmd/config/get_manifest_test.go index 8f16d4114..58d016546 100644 --- a/cmd/config/get_manifest_test.go +++ b/cmd/config/get_manifest_test.go @@ -52,7 +52,7 @@ func TestGetManifestConfigCmd(t *testing.T) { Name: "missing", CmdLine: "manifestMissing", Cmd: cmd.NewGetManifestCommand(settings), - Error: fmt.Errorf("Missing configuration: Manifest with name 'manifestMissing'"), + Error: fmt.Errorf("missing configuration: Manifest with name 'manifestMissing'"), }, { Name: "no-manifests", diff --git a/pkg/bootstrap/isogen/command_test.go b/pkg/bootstrap/isogen/command_test.go index 881181879..70dc42d59 100644 --- a/pkg/bootstrap/isogen/command_test.go +++ b/pkg/bootstrap/isogen/command_test.go @@ -66,7 +66,7 @@ func TestBootstrapIso(t *testing.T) { defer cleanup(t) volBind := tempVol + ":/dst" - testErr := fmt.Errorf("TestErr") + testErr := fmt.Errorf("testErr") testCfg := &config.Bootstrap{ Container: &config.Container{ Volume: volBind, diff --git a/pkg/config/options.go b/pkg/config/options.go index 97c8e8245..96917af6c 100644 --- a/pkg/config/options.go +++ b/pkg/config/options.go @@ -177,7 +177,7 @@ func (o *ManifestOptions) Validate() error { return fmt.Errorf("you must specify a non-empty Manifest name") } if o.RemoteRef != "" { - return fmt.Errorf("Repository checkout by RemoteRef is not yet implemented\n%w", errors.ErrNotImplemented{}) + return fmt.Errorf("repository checkout by RemoteRef is not yet implemented\n%w", errors.ErrNotImplemented{}) } if o.IsPrimary && o.RepoName == "" { return ErrMissingRepositoryName{} diff --git a/pkg/k8s/utils/utils_test.go b/pkg/k8s/utils/utils_test.go index ea991ba3b..b0fbf164a 100644 --- a/pkg/k8s/utils/utils_test.go +++ b/pkg/k8s/utils/utils_test.go @@ -48,16 +48,16 @@ func TestManifestBundleReader(t *testing.T) { }, { name: "Read error", - errString: "Failed to read from bundle", + errString: "failed to read from bundle", reader: fakeReaderWriter{ - readErr: fmt.Errorf("Failed to read from bundle"), + readErr: fmt.Errorf("failed to read from bundle"), }, }, { name: "Write error", - errString: "Failed to write bundle", + errString: "failed to write bundle", writer: fakeReaderWriter{ - writeErr: fmt.Errorf("Failed to write bundle"), + writeErr: fmt.Errorf("failed to write bundle"), }, }, }