58ba1d94e0
The management configuration does not have central validation, leading
to late validation errors. Additionally, there is an effort to provide
better config validation on a command-by-command basis.
This change adds central validation to the management configuration that
will be used several ways:
1. For quicker validation today
2. For a new CLI command that will be introduced in a future change
that enables imperative modification of the management config
3. Possibly in future efforts to provide command-by-command config
validation by calling the exported Validate() function
Change-Id: I19eafddc818e8d478b9afd053d4ab387c7ad38b3
Signed-off-by: Drew Walters <andrew.walters@att.com>
71 lines
1.8 KiB
Go
71 lines
1.8 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
redfishdell "opendev.org/airship/airshipctl/pkg/remote/redfish/vendors/dell"
|
|
)
|
|
|
|
func TestNewManagementConfiguration(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
assert.Equal(t, cfg.Type, config.AirshipDefaultManagementType)
|
|
}
|
|
|
|
func TestSetType(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
|
|
err := cfg.SetType(redfishdell.ClientType)
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, cfg.Type, redfishdell.ClientType)
|
|
}
|
|
|
|
func TestSetTypeInvalid(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
|
|
err := cfg.SetType("invalid")
|
|
require.Error(t, err)
|
|
|
|
assert.Equal(t, cfg.Type, config.AirshipDefaultManagementType)
|
|
}
|
|
func TestValidateDefault(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
|
|
err := cfg.Validate()
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestValidateRedfishDell(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
cfg.Type = redfishdell.ClientType
|
|
|
|
err := cfg.Validate()
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestValidateInvalidManagementType(t *testing.T) {
|
|
cfg := config.NewManagementConfiguration()
|
|
cfg.Type = "invalid"
|
|
|
|
err := cfg.Validate()
|
|
assert.Error(t, err)
|
|
}
|