c70f4a2742
Goland is complaining of a number of bad practices, and unused code. This patchset addresses some of those complaints, such as: - struct initialization without field names - error string should not be capitalized or end with punctuation - name starts with package name - duplicate yaml keys - snake case - redundant parentheses For the http.Transport redundant parentheses, the lint target fails without the use of //nolint:errcheck so it has been added as (currently) there is no potential for there to be an error returned see [0] for example. [0] https://golang.org/src/net/http/transport.go#L42 Change-Id: Ib1b20639c9b6e9be097ef1f158ecd7472f578488 Signed-off-by: Alexander Hughes <Alexander.Hughes@pm.me>
49 lines
1.3 KiB
Go
49 lines
1.3 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package document
|
|
|
|
import (
|
|
"io/ioutil"
|
|
|
|
fs "sigs.k8s.io/kustomize/api/filesys"
|
|
)
|
|
|
|
// File extends kustomize File and provide abstraction to creating temporary files
|
|
type File interface {
|
|
fs.File
|
|
Name() string
|
|
}
|
|
|
|
// FileSystem extends kustomize FileSystem and provide abstraction to creating temporary files
|
|
type FileSystem interface {
|
|
fs.FileSystem
|
|
TempFile(string, string) (File, error)
|
|
}
|
|
|
|
// Fs is adaptor to TempFile
|
|
type Fs struct {
|
|
fs.FileSystem
|
|
}
|
|
|
|
// NewDocumentFs returns an instance of Fs
|
|
func NewDocumentFs() FileSystem {
|
|
return &Fs{FileSystem: fs.MakeFsOnDisk()}
|
|
}
|
|
|
|
// TempFile creates file in temporary filesystem, at default os.TempDir
|
|
func (dfs Fs) TempFile(tmpDir string, prefix string) (File, error) {
|
|
return ioutil.TempFile(tmpDir, prefix)
|
|
}
|