4b729998e9
Invoking remotedirect on a host that is powered off will result in a remotedirect failure; therefore, the power status of a host needs to be verified before remotedirect can begin. This change adds a status check of the ephemeral node before performing remotedirect. When the node is off, airshipctl powers the node on. NOTE: if the host does not power on quickly enough, remotedirect could still fail. The redfish client will be updated to handle the startup and shutdown waiting in another change. Change-Id: I725cf79e070864956e2991f60261328ebd6a5fc5 Signed-off-by: Drew Walters <andrew.walters@att.com>
249 lines
7.0 KiB
Go
249 lines
7.0 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package remote
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
"opendev.org/airship/airshipctl/pkg/environment"
|
|
"opendev.org/airship/airshipctl/pkg/remote/power"
|
|
"opendev.org/airship/airshipctl/pkg/remote/redfish"
|
|
"opendev.org/airship/airshipctl/testutil/redfishutils"
|
|
)
|
|
|
|
const (
|
|
systemID = "System.Embedded.1"
|
|
isoURL = "https://localhost:8080/ubuntu.iso"
|
|
redfishURL = "redfish+https://localhost:2344/Systems/System.Embedded.1"
|
|
username = "admin"
|
|
password = "password"
|
|
)
|
|
|
|
// withRemoteDirectConfig initializes the remote direct settings when used as an argument to "initSettings".
|
|
func withRemoteDirectConfig(cfg *config.RemoteDirect) Configuration {
|
|
return func(settings *environment.AirshipCTLSettings) {
|
|
bootstrapInfo, err := settings.Config.CurrentContextBootstrapInfo()
|
|
if err != nil {
|
|
panic(fmt.Sprintf("Unable to initialize remote direct tests. Current Context error %q", err))
|
|
}
|
|
|
|
bootstrapInfo.RemoteDirect = cfg
|
|
}
|
|
}
|
|
|
|
func TestDoRemoteDirectMissingConfigOpts(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(nil), withTestDataPath("base"))
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestDoRemoteDirectMissingISOURL(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOn, nil)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestDoRemoteDirectRedfish(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOn, nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(nil)
|
|
rMock.On("SetBootSourceByType", ctx).Times(1).Return(nil)
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("RebootSystem", ctx).Times(1).Return(nil)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{
|
|
IsoURL: isoURL,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestDoRemoteDirectRedfishNodePoweredOff(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOff, nil)
|
|
rMock.On("SystemPowerOn", ctx).Times(1).Return(nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(nil)
|
|
rMock.On("SetBootSourceByType", ctx).Times(1).Return(nil)
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("RebootSystem", ctx).Times(1).Return(nil)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{
|
|
IsoURL: isoURL,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestDoRemoteDirectRedfishVirtualMediaError(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
expectedErr := redfish.ErrRedfishClient{Message: "Unable to set virtual media."}
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOn, nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(expectedErr)
|
|
rMock.On("SetBootSourceByType", ctx).Times(1).Return(nil)
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("RebootSystem", ctx).Times(1).Return(nil)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{
|
|
IsoURL: isoURL,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
_, ok := err.(redfish.ErrRedfishClient)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestDoRemoteDirectRedfishBootSourceError(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOn, nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(nil)
|
|
|
|
expectedErr := redfish.ErrRedfishClient{Message: "Unable to set boot source."}
|
|
rMock.On("SetBootSourceByType", ctx).Times(1).Return(expectedErr)
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("RebootSystem", ctx).Times(1).Return(nil)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{
|
|
IsoURL: isoURL,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
_, ok := err.(redfish.ErrRedfishClient)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestDoRemoteDirectRedfishRebootError(t *testing.T) {
|
|
ctx, rMock, err := redfishutils.NewClient(redfishURL, false, false, username, password)
|
|
assert.NoError(t, err)
|
|
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
rMock.On("SystemPowerStatus", ctx).Times(1).Return(power.StatusOn, nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(nil)
|
|
rMock.On("SetVirtualMedia", ctx, isoURL).Times(1).Return(nil)
|
|
rMock.On("SetBootSourceByType", ctx).Times(1).Return(nil)
|
|
rMock.On("NodeID").Times(1).Return(systemID)
|
|
|
|
expectedErr := redfish.ErrRedfishClient{Message: "Unable to set boot source."}
|
|
rMock.On("RebootSystem", ctx).Times(1).Return(expectedErr)
|
|
|
|
ephemeralHost := baremetalHost{
|
|
rMock,
|
|
ctx,
|
|
redfishURL,
|
|
"doc-name",
|
|
username,
|
|
password,
|
|
}
|
|
|
|
cfg := &config.RemoteDirect{
|
|
IsoURL: isoURL,
|
|
}
|
|
|
|
settings := initSettings(t, withRemoteDirectConfig(cfg), withTestDataPath("base"))
|
|
|
|
err = ephemeralHost.DoRemoteDirect(settings)
|
|
_, ok := err.(redfish.ErrRedfishClient)
|
|
assert.True(t, ok)
|
|
}
|