3e44c42989
The KRM based k8s applier solves multiple design problems which were introduced in previous airshipctl generation, making apply code and process more clear, reliable and readable. In particular: * k8s applier now is a KRM function and it allows the end user to choose or implement desired backend for k8s apply operations; * the related amount of code was reduced by three times, multiple unused and unnecessary structs/interfaces/design patterns were removed or rewrited in more clean and efficient way; * removed cli-utils dependency from airshipctl; * fixed several bugs and code issues, such as incorrect printing of tables, duplicated unit tests, improper generation and applying inventory config map, etc; * cli-utils version used in KRM function was bumped to 0.26.0; * phases with duplicated k8s resources were removed or fixed; * unit test coverage increased to 83.1%; * KRM function logs were integrated with klog library which allows to observe logs directly from cli-utils and other dependent libs. Change-Id: Ief509f1d6abefd53caf7fcffc4e36b0319815373 Signed-off-by: Ruslan Aliev <raliev@mirantis.com> Closes: #646
105 lines
2.3 KiB
Go
105 lines
2.3 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package events_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/events"
|
|
k8stest "opendev.org/airship/airshipctl/testutil/k8sutils"
|
|
)
|
|
|
|
func TestDefaultProcessor(t *testing.T) {
|
|
proc := events.NewDefaultProcessor()
|
|
defer proc.Close()
|
|
tests := []struct {
|
|
name string
|
|
events []events.Event
|
|
errString string
|
|
}{
|
|
{
|
|
name: "success",
|
|
events: successEvents(),
|
|
},
|
|
{
|
|
name: "error event",
|
|
events: errEvents(),
|
|
errString: "somerror",
|
|
},
|
|
{
|
|
name: "error event",
|
|
events: errApplyEvents(),
|
|
errString: "somerror",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ch := make(chan events.Event, len(tt.events))
|
|
for _, e := range tt.events {
|
|
ch <- e
|
|
}
|
|
close(ch)
|
|
err := proc.Process(ch)
|
|
if tt.errString != "" {
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.errString)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func successEvents() []events.Event {
|
|
applyEvents := k8stest.SuccessEvents()
|
|
airEvents := []events.Event{}
|
|
for _, e := range applyEvents {
|
|
airEvents = append(airEvents, events.Event{
|
|
Type: events.ApplierType,
|
|
ApplierEvent: e,
|
|
})
|
|
}
|
|
return airEvents
|
|
}
|
|
|
|
func errEvents() []events.Event {
|
|
return []events.Event{
|
|
{
|
|
Type: events.ErrorType,
|
|
ErrorEvent: events.ErrorEvent{
|
|
Error: fmt.Errorf("somerror"),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func errApplyEvents() []events.Event {
|
|
errApplyEvents := k8stest.ErrorEvents()
|
|
airEvents := []events.Event{}
|
|
for _, e := range errApplyEvents {
|
|
airEvents = append(airEvents, events.Event{
|
|
Type: events.ApplierType,
|
|
ApplierEvent: e,
|
|
})
|
|
}
|
|
return airEvents
|
|
}
|