![Alexander Hughes](/assets/img/avatar_default.png)
Goland is complaining of a number of bad practices, and unused code. This patchset addresses some of those complaints, such as: - struct initialization without field names - error string should not be capitalized or end with punctuation - name starts with package name - duplicate yaml keys - snake case - redundant parentheses For the http.Transport redundant parentheses, the lint target fails without the use of //nolint:errcheck so it has been added as (currently) there is no potential for there to be an error returned see [0] for example. [0] https://golang.org/src/net/http/transport.go#L42 Change-Id: Ib1b20639c9b6e9be097ef1f158ecd7472f578488 Signed-off-by: Alexander Hughes <Alexander.Hughes@pm.me>
36 lines
1.2 KiB
Go
36 lines
1.2 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cluster
|
|
|
|
import (
|
|
"github.com/spf13/cobra"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/environment"
|
|
)
|
|
|
|
// NewClusterCommand returns cobra command object of the airshipctl cluster and adds it's subcommands.
|
|
func NewClusterCommand(rootSettings *environment.AirshipCTLSettings) *cobra.Command {
|
|
clusterRootCmd := &cobra.Command{
|
|
Use: "cluster",
|
|
// TODO: (kkalynovskyi) Add more description when more subcommands are added
|
|
Short: "Control Kubernetes cluster",
|
|
Long: "Interactions with Kubernetes cluster, such as get status, deploy initial infrastructure",
|
|
}
|
|
|
|
clusterRootCmd.AddCommand(NewCmdInitInfra(rootSettings))
|
|
|
|
return clusterRootCmd
|
|
}
|