This change causes the linter to be a bit more complainy. The hope is that this will cut down on some of the more pedantic issues being caught in code reviews, and thus reduce the overall time a change spends in the review process. This change includes various changes to the codebase to bring it up to the new standards. Change-Id: I570d304bca5554404354f972d8a2743279a0171b
80 lines
1.7 KiB
Go
80 lines
1.7 KiB
Go
package remote
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
redfish "opendev.org/airship/airshipctl/pkg/remote/redfish"
|
|
)
|
|
|
|
func TestUnknownRemoteType(t *testing.T) {
|
|
rdCfg := RemoteDirectConfig{
|
|
RemoteType: "new-remote",
|
|
RemoteURL: "http://localhost:8000",
|
|
EphemeralNodeId: "test-node",
|
|
IsoPath: "/test.iso",
|
|
}
|
|
|
|
err := DoRemoteDirect(rdCfg)
|
|
|
|
_, ok := err.(*RemoteDirectError)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestRedfishRemoteDirectWithBogusConfig(t *testing.T) {
|
|
rdCfg := RemoteDirectConfig{
|
|
RemoteType: "redfish",
|
|
RemoteURL: "http://nolocalhost:8888",
|
|
EphemeralNodeId: "test-node",
|
|
IsoPath: "/test.iso",
|
|
}
|
|
|
|
err := DoRemoteDirect(rdCfg)
|
|
|
|
_, ok := err.(*redfish.RedfishClientError)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestRedfishRemoteDirectWithEmptyURL(t *testing.T) {
|
|
rdCfg := RemoteDirectConfig{
|
|
RemoteType: "redfish",
|
|
RemoteURL: "",
|
|
EphemeralNodeId: "test-node",
|
|
IsoPath: "/test.iso",
|
|
}
|
|
|
|
err := DoRemoteDirect(rdCfg)
|
|
|
|
_, ok := err.(*redfish.RedfishConfigError)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestRedfishRemoteDirectWithEmptyNodeID(t *testing.T) {
|
|
rdCfg := RemoteDirectConfig{
|
|
RemoteType: "redfish",
|
|
RemoteURL: "http://nolocalhost:8888",
|
|
EphemeralNodeId: "",
|
|
IsoPath: "/test.iso",
|
|
}
|
|
|
|
err := DoRemoteDirect(rdCfg)
|
|
|
|
_, ok := err.(*redfish.RedfishConfigError)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func TestRedfishRemoteDirectWithEmptyIsoPath(t *testing.T) {
|
|
rdCfg := RemoteDirectConfig{
|
|
RemoteType: "redfish",
|
|
RemoteURL: "http://nolocalhost:8888",
|
|
EphemeralNodeId: "123",
|
|
IsoPath: "",
|
|
}
|
|
|
|
err := DoRemoteDirect(rdCfg)
|
|
|
|
_, ok := err.(*redfish.RedfishConfigError)
|
|
assert.True(t, ok)
|
|
}
|