c70f4a2742
Goland is complaining of a number of bad practices, and unused code. This patchset addresses some of those complaints, such as: - struct initialization without field names - error string should not be capitalized or end with punctuation - name starts with package name - duplicate yaml keys - snake case - redundant parentheses For the http.Transport redundant parentheses, the lint target fails without the use of //nolint:errcheck so it has been added as (currently) there is no potential for there to be an error returned see [0] for example. [0] https://golang.org/src/net/http/transport.go#L42 Change-Id: Ib1b20639c9b6e9be097ef1f158ecd7472f578488 Signed-off-by: Alexander Hughes <Alexander.Hughes@pm.me>
43 lines
972 B
YAML
43 lines
972 B
YAML
# this is a legacy CRD which defines a type whose status can be checked using
|
|
# the condition in the annotations
|
|
# It is included in tests to assure backward compatibility
|
|
apiVersion: apiextensions.k8s.io/v1beta1
|
|
kind: CustomResourceDefinition
|
|
metadata:
|
|
name: legacies.example.com
|
|
annotations:
|
|
airshipit.org/status-check: |
|
|
[
|
|
{
|
|
"status": "Stable",
|
|
"condition": "@.status.state==\"stable\""
|
|
},
|
|
{
|
|
"status": "Pending",
|
|
"condition": "@.status.state==\"pending\""
|
|
}
|
|
]
|
|
spec:
|
|
group: example.com
|
|
versions:
|
|
- name: v1
|
|
served: true
|
|
storage: true
|
|
scope: Namespaced
|
|
names:
|
|
plural: legacies
|
|
singular: legacy
|
|
kind: Legacy
|
|
shortNames:
|
|
- lgc
|
|
preserveUnknownFields: false
|
|
validation:
|
|
openAPIV3Schema:
|
|
type: object
|
|
properties:
|
|
status:
|
|
type: object
|
|
properties:
|
|
state:
|
|
type: string
|