585af5a516
This change fixes a bug where the default values that are populated during an `airshipctl config init` were getting mixed in with user specified values at runtime. For example, a user with two contexts defined in their airship config file would actually see a third phantom context with default values in the output of `airshipctl config get-context`. Also fixes a number of the config cmd and pkg unit tests that were affected by this bug. Change-Id: Iac591d4c2a616090028eb730576478edefb82544 Closes: #447
146 lines
3.7 KiB
Go
146 lines
3.7 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config_test
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
cmd "opendev.org/airship/airshipctl/cmd/config"
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
"opendev.org/airship/airshipctl/testutil"
|
|
)
|
|
|
|
const (
|
|
mName = "dummymanifest"
|
|
mRepoName = "treasuremap"
|
|
mURL = "https://github.com/airshipit/treasuremap"
|
|
mBranch = "master"
|
|
mTargetPath = "/tmp/airship"
|
|
mMetadataPath = "manifests/metadata.yaml"
|
|
|
|
testTargetPath = "/tmp/e2e"
|
|
testMetadataPath = "manifests/docker_metadata.yaml"
|
|
)
|
|
|
|
type setManifestTest struct {
|
|
inputConfig *config.Config
|
|
cmdTest *testutil.CmdTest
|
|
manifestName string
|
|
manifestTargetPath string
|
|
manifestMetadataPath string
|
|
}
|
|
|
|
func TestConfigSetManifest(t *testing.T) {
|
|
cmdTests := []*testutil.CmdTest{
|
|
{
|
|
Name: "config-cmd-set-manifest-with-help",
|
|
CmdLine: "--help",
|
|
Cmd: cmd.NewSetManifestCommand(nil),
|
|
},
|
|
{
|
|
Name: "config-cmd-set-manifest-too-many-args",
|
|
CmdLine: "arg1 arg2",
|
|
Cmd: cmd.NewSetManifestCommand(nil),
|
|
Error: fmt.Errorf("accepts %d arg(s), received %d", 1, 2),
|
|
},
|
|
{
|
|
Name: "config-cmd-set-manifest-too-few-args",
|
|
CmdLine: "",
|
|
Cmd: cmd.NewSetManifestCommand(nil),
|
|
Error: fmt.Errorf("accepts %d arg(s), received %d", 1, 0),
|
|
},
|
|
}
|
|
|
|
for _, tt := range cmdTests {
|
|
testutil.RunTest(t, tt)
|
|
}
|
|
}
|
|
|
|
func TestSetManifest(t *testing.T) {
|
|
given, cleanupGiven := testutil.InitConfig(t)
|
|
defer cleanupGiven(t)
|
|
|
|
tests := []struct {
|
|
testName string
|
|
manifestName string
|
|
flags []string
|
|
givenConfig *config.Config
|
|
targetPath string
|
|
metadataPath string
|
|
}{
|
|
{
|
|
testName: "set-manifest",
|
|
manifestName: mName,
|
|
flags: []string{
|
|
"--repo " + mRepoName,
|
|
"--url " + mURL,
|
|
"--branch " + mBranch,
|
|
"--phase",
|
|
"--target-path " + mTargetPath,
|
|
"--metadata-path " + mMetadataPath,
|
|
},
|
|
givenConfig: given,
|
|
targetPath: mTargetPath,
|
|
metadataPath: mMetadataPath,
|
|
},
|
|
{
|
|
testName: "modify-manifest",
|
|
manifestName: mName,
|
|
flags: []string{
|
|
"--target-path " + testTargetPath,
|
|
"--metadata-path " + testMetadataPath,
|
|
},
|
|
givenConfig: given,
|
|
targetPath: testTargetPath,
|
|
metadataPath: mMetadataPath,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
cmd := &testutil.CmdTest{
|
|
Name: tt.testName,
|
|
CmdLine: fmt.Sprintf("%s %s", tt.manifestName, strings.Join(tt.flags, " ")),
|
|
}
|
|
test := setManifestTest{
|
|
inputConfig: tt.givenConfig,
|
|
cmdTest: cmd,
|
|
manifestName: tt.manifestName,
|
|
manifestTargetPath: tt.targetPath,
|
|
manifestMetadataPath: tt.metadataPath,
|
|
}
|
|
test.run(t)
|
|
}
|
|
}
|
|
|
|
func (test setManifestTest) run(t *testing.T) {
|
|
settings := func() (*config.Config, error) {
|
|
return test.inputConfig, nil
|
|
}
|
|
test.cmdTest.Cmd = cmd.NewSetManifestCommand(settings)
|
|
testutil.RunTest(t, test.cmdTest)
|
|
|
|
afterRunConf := test.inputConfig
|
|
// Find the Manifest Created or Modified
|
|
afterRunManifest := afterRunConf.Manifests[test.manifestName]
|
|
require.NotNil(t, afterRunManifest)
|
|
assert.EqualValues(t, afterRunManifest.TargetPath, test.manifestTargetPath)
|
|
}
|