753d8a456c
By specifying any other branch rather than master in airshipctl config, `airshipctl document pull` command failing with `reference not found` error. The resulted target dir, after execution, still pointing to master. The idea of this change is to use checkout options during the clone stage, so we will be clonning the specific branch. Added debug log about cloning default(master) branch in case of missing checkout options. Enabled validation for incompatible parameters in checkout options. Aligned unit tests with code changes. Closes: #197 Change-Id: I50ac18289a8f02997d5b90c82f1688083cff8bf3
290 lines
7.1 KiB
Go
290 lines
7.1 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"sigs.k8s.io/yaml"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
)
|
|
|
|
const (
|
|
validateTestName = "ToCheckout"
|
|
validateFailuresTestName = "Validate"
|
|
toAuthTestName = "ToAuth"
|
|
toAuthNilTestName = "ToAuthNil"
|
|
ToFetchOptionsTestName = "ToFetchOptions"
|
|
ToCloneOptionsTestName = "ToCloneOptions"
|
|
toAuthNilError = "toAuthNilError"
|
|
URLTestName = "URLTest"
|
|
StringTestData = `test-data:
|
|
no-auth:
|
|
url: https://github.com/go-git/go-git.git
|
|
checkout:
|
|
tag: v3.0.0
|
|
ssh-key-auth:
|
|
url: git@github.com:go-git/go-git.git
|
|
auth:
|
|
type: ssh-key
|
|
sshKey: "testdata/test-key.pem"
|
|
username: git
|
|
checkout:
|
|
branch: master
|
|
ssh-pass:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: ssh-pass
|
|
sshPass: "qwerty123"
|
|
username: deployer
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
|
|
http-basic-auth:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: http-basic
|
|
httpPass: "qwerty123"
|
|
username: deployer
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
|
|
empty-checkout:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: http-basic
|
|
httpPass: "qwerty123"
|
|
username: deployer
|
|
wrong-type-auth:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: wrong-type
|
|
httpPass: "qwerty123"
|
|
username: deployer
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
|
|
mutually-exclusive-auth-opts:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: http-basic
|
|
sshKey: "/path-to-key"
|
|
username: deployer
|
|
mutually-exclusive-checkout-opts:
|
|
url: /home/ubuntu/some-gitrepo
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
|
|
branch: master
|
|
mutually-exclusive-auth-opts-ssh-key:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: ssh-key
|
|
httpPass: "qwerty123"
|
|
sshKey: "/path-to-key"
|
|
username: deployer
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
|
|
mutually-exclusive-auth-opts-ssh-pass:
|
|
url: /home/ubuntu/some-gitrepo
|
|
auth:
|
|
type: ssh-pass
|
|
sshPass: "qwerty123"
|
|
httpPass: "qwerty123"
|
|
sshKey: "/path-to-key"
|
|
username: deployer
|
|
checkout:
|
|
commitHash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8`
|
|
)
|
|
|
|
var (
|
|
TestCaseMap = map[string]*TestCase{
|
|
validateTestName: {
|
|
expectError: false,
|
|
dataMapEntry: []string{"http-basic-auth", "ssh-key-auth", "no-auth", "empty-checkout"},
|
|
expectedNil: false,
|
|
},
|
|
validateFailuresTestName: {
|
|
expectError: true,
|
|
dataMapEntry: []string{"wrong-type-auth",
|
|
"mutually-exclusive-auth-opts",
|
|
"mutually-exclusive-checkout-opts",
|
|
"mutually-exclusive-auth-opts-ssh-key",
|
|
"mutually-exclusive-auth-opts-ssh-pass"},
|
|
expectedNil: false,
|
|
},
|
|
toAuthTestName: {
|
|
expectError: false,
|
|
dataMapEntry: []string{"ssh-key-auth",
|
|
"http-basic-auth",
|
|
"ssh-pass"},
|
|
|
|
expectedNil: false,
|
|
},
|
|
toAuthNilError: {
|
|
expectError: true,
|
|
dataMapEntry: []string{"wrong-type-auth"},
|
|
expectedNil: true,
|
|
},
|
|
toAuthNilTestName: {
|
|
expectError: false,
|
|
dataMapEntry: []string{"no-auth"},
|
|
expectedNil: true,
|
|
},
|
|
ToFetchOptionsTestName: {
|
|
expectError: false,
|
|
dataMapEntry: []string{"no-auth"},
|
|
expectedNil: false,
|
|
},
|
|
ToCloneOptionsTestName: {
|
|
expectError: false,
|
|
dataMapEntry: []string{"http-basic-auth", "ssh-key-auth", "no-auth", "empty-checkout"},
|
|
expectedNil: false,
|
|
},
|
|
URLTestName: {
|
|
expectError: false,
|
|
expectedNil: false,
|
|
dataMapEntry: []string{"no-auth"},
|
|
},
|
|
}
|
|
)
|
|
|
|
type TestCase struct {
|
|
expectError bool
|
|
// this maps to TestData map in TestRepos struct
|
|
dataMapEntry []string
|
|
expectedNil bool
|
|
}
|
|
|
|
type TestRepos struct {
|
|
TestData map[string]*config.Repository `json:"test-data"`
|
|
}
|
|
|
|
func TestToCheckout(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
testCase := TestCaseMap[validateTestName]
|
|
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
require.NotNil(t, repo)
|
|
co := repo.ToCheckoutOptions(false)
|
|
if testCase.expectedNil {
|
|
assert.Nil(t, co)
|
|
} else {
|
|
assert.NotNil(t, co)
|
|
assert.NoError(t, co.Validate())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestToAuth(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
for _, testCaseName := range []string{toAuthTestName, toAuthNilTestName, toAuthNilError} {
|
|
testCase := TestCaseMap[testCaseName]
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
auth, authErr := repo.ToAuth()
|
|
if testCase.expectError {
|
|
assert.Error(t, authErr)
|
|
} else {
|
|
assert.NoError(t, authErr)
|
|
}
|
|
if testCase.expectedNil {
|
|
assert.Nil(t, auth)
|
|
} else {
|
|
assert.NotNil(t, auth)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateRepository(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
for _, testCaseName := range []string{validateTestName, validateFailuresTestName} {
|
|
testCase := TestCaseMap[testCaseName]
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
err := repo.Validate()
|
|
if testCase.expectError {
|
|
assert.Error(t, err)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
if testCase.expectedNil {
|
|
assert.Nil(t, repo)
|
|
} else {
|
|
assert.NotNil(t, repo)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestToFetchOptions(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
testCase := TestCaseMap[ToFetchOptionsTestName]
|
|
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
require.NotNil(t, repo)
|
|
assert.NotNil(t, repo.ToFetchOptions(nil))
|
|
}
|
|
}
|
|
|
|
func TestToCloneOptions(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
testCase := TestCaseMap[ToCloneOptionsTestName]
|
|
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
require.NotNil(t, repo)
|
|
cl := repo.ToCloneOptions(nil)
|
|
if testCase.expectedNil {
|
|
assert.Nil(t, cl)
|
|
} else {
|
|
assert.NotNil(t, cl)
|
|
assert.NoError(t, cl.Validate())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestURL(t *testing.T) {
|
|
data := &TestRepos{}
|
|
err := yaml.Unmarshal([]byte(StringTestData), data)
|
|
require.NoError(t, err)
|
|
|
|
testCase := TestCaseMap[URLTestName]
|
|
|
|
for _, name := range testCase.dataMapEntry {
|
|
repo := data.TestData[name]
|
|
require.NotNil(t, repo)
|
|
assert.Equal(t, repo.URLString, repo.URL())
|
|
}
|
|
}
|