cc46ae2ef4
Sometimes unit test for showProgress function fails if progress bar was not finished before refreshing event occurs, so progress bar prints to io.Writer its intermediate state (which is normal since in regular terminal the output everytime overwrites by carriage return), so expected and actual output become different. This PS changes the concept of testing this function and adds the error tracking of showProgress execution. Some other minor changes included. Change-Id: I78b4fa9674d4412fa83c1e9320b686923cbe8084 Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
45 lines
1.1 KiB
Go
45 lines
1.1 KiB
Go
/*
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package image
|
|
|
|
import (
|
|
"github.com/spf13/cobra"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/bootstrap/isogen"
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
)
|
|
|
|
// NewImageBuildCommand creates a new command with the capability to build an ISO image.
|
|
func NewImageBuildCommand(cfgFactory config.Factory) *cobra.Command {
|
|
var progress bool
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "build",
|
|
Short: "Build ISO image",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return isogen.GenerateBootstrapIso(cfgFactory, progress)
|
|
},
|
|
}
|
|
|
|
flags := cmd.Flags()
|
|
flags.BoolVar(
|
|
&progress,
|
|
"progress",
|
|
false,
|
|
"show progress")
|
|
|
|
return cmd
|
|
}
|