airshipctl/pkg/config/repo_test.go
Alan Meadows 16bc0cc81c Properly locate tests within a config_test pkg for pkg/config and cmd/config
This relocates tests that were improperly placed within the config pkg for both
the pkg/config and cmd/config packages. These were causing testutil to be imported
outside of tests causing a cyclic import issue when trying to import the config
pkg within the document pkg.

This patchset moves the tests as well as refactoring several of them where they
were leveraging private attributes which cannot be accessed as an external test
pkg.

Closes: #109
Relates-To: #107

Change-Id: Ib1bf2aff020599ba0b3f5a7fd7fadf737b8c86b8
2020-03-11 16:21:57 -07:00

264 lines
6.3 KiB
Go

package config_test
import (
"testing"
"sigs.k8s.io/yaml"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"opendev.org/airship/airshipctl/pkg/config"
)
const (
validateTestName = "ToCheckout"
validateFailuresTestName = "Validate"
toAuthTestName = "ToAuth"
toAuthNilTestName = "ToAuthNil"
ToFetchOptionsTestName = "ToFetchOptions"
toAuthNilError = "toAuthNilError"
URLTestName = "URLTest"
StringTestData = `test-data:
no-auth:
url: https://github.com/src-d/go-git.git
checkout:
tag: v3.0.0
ssh-key-auth:
url: git@github.com:src-d/go-git.git
auth:
type: ssh-key
ssh-key: "testdata/test-key.pem"
username: git
checkout:
branch: master
ssh-pass:
url: /home/ubuntu/some-gitrepo
auth:
type: ssh-pass
ssh-pass: "qwerty123"
username: deployer
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
http-basic-auth:
url: /home/ubuntu/some-gitrepo
auth:
type: http-basic
http-pass: "qwerty123"
username: deployer
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
empty-checkout:
url: /home/ubuntu/some-gitrepo
auth:
type: http-basic
http-pass: "qwerty123"
username: deployer
wrong-type-auth:
url: /home/ubuntu/some-gitrepo
auth:
type: wrong-type
http-pass: "qwerty123"
username: deployer
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
mutually-exclusive-auth-opts:
url: /home/ubuntu/some-gitrepo
auth:
type: http-basic
ssh-key: "/path-to-key"
username: deployer
mutually-exclusive-checkout-opts:
url: /home/ubuntu/some-gitrepo
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
branch: master
mutually-exclusive-auth-opts-ssh-key:
url: /home/ubuntu/some-gitrepo
auth:
type: ssh-key
http-pass: "qwerty123"
ssh-key: "/path-to-key"
username: deployer
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8
mutually-exclusive-auth-opts-ssh-pass:
url: /home/ubuntu/some-gitrepo
auth:
type: ssh-pass
ssh-pass: "qwerty123"
http-pass: "qwerty123"
ssh-key: "/path-to-key"
username: deployer
checkout:
commit-hash: 01c4f7f32beb9851ae8f119a6b8e497d2b1e2bb8`
)
var (
TestCaseMap = map[string]*TestCase{
validateTestName: {
expectError: false,
dataMapEntry: []string{"http-basic-auth", "ssh-key-auth", "no-auth", "empty-checkout"},
expectedNil: false,
},
validateFailuresTestName: {
expectError: true,
dataMapEntry: []string{"wrong-type-auth",
"mutually-exclusive-auth-opts",
"mutually-exclusive-checkout-opts",
"mutually-exclusive-auth-opts-ssh-key",
"mutually-exclusive-auth-opts-ssh-pass"},
expectedNil: false,
},
toAuthTestName: {
expectError: false,
dataMapEntry: []string{"ssh-key-auth",
"http-basic-auth",
"ssh-pass"},
expectedNil: false,
},
toAuthNilError: {
expectError: true,
dataMapEntry: []string{"wrong-type-auth"},
expectedNil: true,
},
toAuthNilTestName: {
expectError: false,
dataMapEntry: []string{"no-auth"},
expectedNil: true,
},
ToFetchOptionsTestName: {
expectError: false,
dataMapEntry: []string{"no-auth"},
expectedNil: false,
},
URLTestName: {
expectError: false,
expectedNil: false,
dataMapEntry: []string{"no-auth"},
},
}
)
type TestCase struct {
expectError bool
// this maps to TestData map in TestRepos struct
dataMapEntry []string
expectedNil bool
}
type TestRepos struct {
TestData map[string]*config.Repository `json:"test-data"`
}
func TestToCheckout(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
testCase := TestCaseMap[validateTestName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
require.NotNil(t, repo)
co := repo.ToCheckoutOptions(false)
if testCase.expectedNil {
assert.Nil(t, co)
} else {
assert.NotNil(t, co)
assert.NoError(t, co.Validate())
}
}
}
func TestToAuth(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
for _, testCaseName := range []string{toAuthTestName, toAuthNilTestName, toAuthNilError} {
testCase := TestCaseMap[testCaseName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
auth, authErr := repo.ToAuth()
if testCase.expectError {
assert.Error(t, authErr)
} else {
assert.NoError(t, authErr)
}
if testCase.expectedNil {
assert.Nil(t, auth)
} else {
assert.NotNil(t, auth)
}
}
}
}
func TestValidateRepository(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
for _, testCaseName := range []string{validateTestName, validateFailuresTestName} {
testCase := TestCaseMap[testCaseName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
err := repo.Validate()
if testCase.expectError {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
if testCase.expectedNil {
assert.Nil(t, repo)
} else {
assert.NotNil(t, repo)
}
}
}
}
func TestToFetchOptions(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
testCase := TestCaseMap[ToFetchOptionsTestName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
require.NotNil(t, repo)
assert.NotNil(t, repo.ToFetchOptions(nil))
}
}
func TestToCloneOptions(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
testCase := TestCaseMap[ToFetchOptionsTestName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
require.NotNil(t, repo)
assert.NotNil(t, repo.ToCloneOptions(nil))
}
}
func TestURL(t *testing.T) {
data := &TestRepos{}
err := yaml.Unmarshal([]byte(StringTestData), data)
require.NoError(t, err)
testCase := TestCaseMap[URLTestName]
for _, name := range testCase.dataMapEntry {
repo := data.TestData[name]
require.NotNil(t, repo)
assert.Equal(t, repo.URLString, repo.URL())
}
}