From 11fc56be31d828621679a001ac240bd47320b187 Mon Sep 17 00:00:00 2001
From: Matthew Fuller <mf4192@att.com>
Date: Fri, 11 Dec 2020 22:51:53 +0000
Subject: [PATCH] Add missing error messages

Adds missing validation error messages to various config
components for more helpful feedback to user.

Change-Id: I68da65193971cf66488bda4efc855ce31e40707f
---
 .../config-encryption.component.html                 | 12 ++++++++++++
 .../config-management.component.html                 |  6 ++++++
 .../config-manifest/config-manifest.component.html   | 12 ++++++++++++
 .../repository/repository.component.html             |  9 +++++++++
 4 files changed, 39 insertions(+)

diff --git a/client/src/app/ctl/config/config-encryption/config-encryption.component.html b/client/src/app/ctl/config/config-encryption/config-encryption.component.html
index 6e82803..f53bf4b 100644
--- a/client/src/app/ctl/config/config-encryption/config-encryption.component.html
+++ b/client/src/app/ctl/config/config-encryption/config-encryption.component.html
@@ -9,20 +9,32 @@
                 <mat-form-field appearance="fill">
                     <mat-label>EncryptionKeyPath</mat-label>
                     <input matInput formControlName="encryptionKeyPath">
+                    <mat-error *ngIf="group.controls.encryptionKeyPath.hasError('required')">
+                        EncryptionKeyPath path is required
+                    </mat-error>
                 </mat-form-field>
                 <mat-form-field appearance="fill">
                     <mat-label>DecryptionKeyPath</mat-label>
                     <input matInput formControlName="decryptionKeyPath">
+                    <mat-error *ngIf="group.controls.decryptionKeyPath.hasError('required')">
+                        DecryptionKeyPath is required
+                    </mat-error>
                 </mat-form-field>
             </div>
             <div *ngIf="config.hasOwnProperty('keySecretName')">
                 <mat-form-field appearance="fill">
                     <mat-label>KeySecretName</mat-label>
                     <input matInput formControlName="keySecretName">
+                    <mat-error *ngIf="group.controls.keySecretName.hasError('required')">
+                        KeySecretName is required
+                    </mat-error>
                 </mat-form-field>
                 <mat-form-field appearance="fill">
                     <mat-label>KeySecretNamespace</mat-label>
                     <input matInput formControlName="keySecretNamespace">
+                    <mat-error *ngIf="group.controls.keySecretNamespace.hasError('required')">
+                        KeySecretNamespace is required
+                    </mat-error>
                 </mat-form-field>
             </div>
         </form>
diff --git a/client/src/app/ctl/config/config-management/config-management.component.html b/client/src/app/ctl/config/config-management/config-management.component.html
index 7994969..d45a488 100644
--- a/client/src/app/ctl/config/config-management/config-management.component.html
+++ b/client/src/app/ctl/config/config-management/config-management.component.html
@@ -11,10 +11,16 @@
             <mat-form-field appearance="fill">
                 <mat-label>System Action Retries</mat-label>
                 <input matInput formControlName="systemActionRetries" placeholder="Value in seconds, e.g. 30">
+                <mat-error *ngIf="group.controls.systemActionRetries.hasError('pattern')">
+                    Value must be a number
+                </mat-error>
             </mat-form-field><br />
             <mat-form-field appearance="fill">
                 <mat-label>System Reboot Delay</mat-label>
                 <input matInput formControlName="systemRebootDelay" placeholder="Value in seconds, e.g. 30">
+                <mat-error *ngIf="group.controls.systemRebootDelay.hasError('pattern')">
+                    Value must be a number
+                </mat-error>
             </mat-form-field><br />
             <mat-form-field appearance="fill">
                 <mat-label>Type</mat-label>
diff --git a/client/src/app/ctl/config/config-manifest/config-manifest.component.html b/client/src/app/ctl/config/config-manifest/config-manifest.component.html
index ad81d10..d454c13 100644
--- a/client/src/app/ctl/config/config-manifest/config-manifest.component.html
+++ b/client/src/app/ctl/config/config-manifest/config-manifest.component.html
@@ -8,10 +8,16 @@
         <mat-form-field appearance="fill">
             <mat-label>Target Path</mat-label>
             <input matInput formControlName="targetPath">
+            <mat-error *ngIf="group.controls.targetPath.hasError('required')">
+                Target Path is required
+            </mat-error>
         </mat-form-field>
         <mat-form-field appearance="fill">
             <mat-label>Metadata Path</mat-label>
             <input matInput formControlName="metadataPath">
+            <mat-error *ngIf="group.controls.metadataPath.hasError('required')">
+                Metadata Path is required
+            </mat-error>
         </mat-form-field>
         <h5>Repositories</h5>
         <mat-form-field appearance="fill">
@@ -24,10 +30,16 @@
                 <mat-form-field appearance="fill">
                     <mat-label>URL</mat-label>
                     <input matInput formControlName="url">
+                    <mat-error *ngIf="repo.controls.url.hasError('required')">
+                        URL is required
+                    </mat-error>
                 </mat-form-field>
                 <mat-form-field appearance="fill">
                     <mat-label>{{repo.controls.checkoutLabel.value}}</mat-label>
                     <input matInput formControlName="checkoutReference">
+                    <mat-error *ngIf="repo.controls.checkoutReference.hasError('required')">
+                        {{repo.controls.checkoutLabel.value}} is required
+                    </mat-error>
                 </mat-form-field>
                 <p>
                     <mat-checkbox formControlName="force" labelPosition="after">Force</mat-checkbox>
diff --git a/client/src/app/ctl/config/config-manifest/repository/repository.component.html b/client/src/app/ctl/config/config-manifest/repository/repository.component.html
index 5f1d185..af5c900 100644
--- a/client/src/app/ctl/config/config-manifest/repository/repository.component.html
+++ b/client/src/app/ctl/config/config-manifest/repository/repository.component.html
@@ -3,10 +3,16 @@
     <mat-form-field appearance="fill">
         <mat-label>Repository Name</mat-label>
         <input matInput formControlName="repoName">
+        <mat-error *ngIf="group.controls.repoName.hasError('required')">
+            Repository Name is required
+        </mat-error>
     </mat-form-field>
     <mat-form-field appearance="fill">
         <mat-label>URL</mat-label>
         <input matInput formControlName="url">
+        <mat-error *ngIf="group.controls.url.hasError('required')">
+            URL is required
+        </mat-error>
     </mat-form-field>
     <mat-label>
         <mat-select [(value)]="checkoutType">
@@ -15,6 +21,9 @@
     </mat-label>
     <mat-form-field appearance="fill">
         <input matInput formControlName="checkoutReference">
+        <mat-error *ngIf="group.controls.checkoutReference.hasError('required')">
+            {{checkoutType}} is required
+        </mat-error>
     </mat-form-field>
     <p>
         <mat-checkbox formControlName="force" labelPosition="after">Force</mat-checkbox>