This patch does the following:
1. Simplify the client websocket message transformation
2. Move the cmd/airshipui to cmd
3. move internal to pkg
4. Clean up the copyright checker
5. clean up the linting in the makefile
Change-Id: I1381d025e8058cbfba44b58ec3c2ec5c2aa36de5
Issues addressed:
* package comment should not have leading space
* exported var UiConfig should have comment or be unexported
* if block ends with a return statement, so drop this else and outdent its block
* var UiConfig should be UIConfig
Change-Id: I04b380445d7c97a816f75a9af006d2461b256356
Removing octant reference for now, it will need to be
later embedded into the ui
Working on this will require these commands to be run in
the web directory:
npm install
npm install --save-dev electron
behind a proxy npm install may have issues, this might work:
npx cross-env ELECTRON_GET_USE_PROXY=true GLOBAL_AGENT_HTTPS_PROXY=
http://<proxy>:<port> npm install -D electron@latest
Change-Id: I5bd054a767fe8ab7b0461a16eced1921c4de11f6
Brought over the .golangci.yaml file from airshipctl
Made necessiary corrections based on it
The goimports section in .golangi.yaml will need to be addressed,
not currently working for airshipui
Change-Id: I43973224703408a3320e43a59b4639d6d3edd1ca
- Simplified the Getting Started steps and seperated out Prereqs
- Moved Argo UI instructions to its own README and linked to it in
the developer's guide
Change-Id: Iec3cfbb6a00d7886f5b4e66f8aa8923d15226ae6
Fixes #24
Fixes #22
It introduces gophercloud for OpenStack components
This also brings the argoui plugin up to the current latest
version of the plugin structure
Change-Id: Ie5e7e2434970f0775701c9b0d851817ef476d7e4
- A proxy or port forward should not be necessary to show the Argo UI
instead the endpoint should be used to eliminate user steps
- Remove proxy instructions in Developers Guide
- Remove nested pages. Only one page is necessary - the Argo UI
- Update Octant to latest version on master
- Remove TestRouteHandles as a service.Request cannot be created that
can be used by getArgoUIURL. The functions are not exported
Change-Id: I2a69d3804474f21baafa5e0388eefd569d9ca1a2
Create airshipui executable that derives kube config from the airshipctl
settings and launches octant. The executable has its own set of
command-line options, which may be expanded in the future to perform
additional setup before launching octant.
Note that octant currently does not support being compiled together and
called as a function from other code, but that support should be coming
in the future.
Remove goimports check from lint suite since it generates undecipherable
(and sometimes unsolvable) false positives and does not substantively
improve on "go fmt".
Change-Id: Iad1530f536fcbae93a92a4e827dbb7aece5231fa
Integrate golangci-lint, which is a full-featured linter tool that
includes the checks from 'go vet' and many more. Borrowed the
install_linter script from airship/airshipctl to install the script
from upstream. Address issues uncovered by the tool.
Change-Id: If30e0819f5d03243e4004bca07951f8aa5218749
Introduces new convention for plugins that fixes
multi plugin support
Each plugin name will exist at :
- cmd/<plugin name>/main.go
Definitions to call plugin registration
- internal/plugin/<plugin name>
Implementations for Navigation, Tab and Print as appropriate
Change-Id: I6f5e71900eb90b26917216ebd1a2749acc4f5a52
