airship/armada
Code Issues Proposed changes

test(chartbuilder): Additional chartbuilder unit tests

Browse Source 
This adds unit tests for the following ChartBuilder scenarios:

  - ChartBuilder dump method (base case and recursive case)
  - ChartBuilder get_helm_chart method using a chart with dependencies
    to test the recursive case

Change-Id: Icd1f284b869c0ea597697d7e73ff0ab94423e4ac
This commit is contained in:
Felipe Monteiro
2018-01-10 22:25:47 +00:00
parent a16a1e24a7
commit 10e084a200
2 changed files with 160 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
armada/handlers/chartbuilder.py
View File

@@ -222,8 +222,8 @@ class ChartBuilder(object):
dependencies = []
for dep in self.chart.dependencies:
LOG.info("Building dependency chart %s for release %s",
self.chart.chart_name, self.chart.release)
LOG.info("Building dependency chart %s for release %s.",
dep.chart.chart_name, dep.chart.release)
try:
dependencies.append(ChartBuilder(dep.chart).get_helm_chart())
except Exception: