Browse Source

Add warnings for post upgrade actions

Armada does not perform post upgrade actions. This change adds a warning
to the documentation, comments, and output.

Change-Id: I4d37406e13a44759861ea179d06b26831efe2ac8
Drew Walters 5 months ago
parent
commit
4b76fda6b4

+ 2
- 0
armada/handlers/chart_deploy.py View File

@@ -132,6 +132,8 @@ class ChartDeploy(object):
132 132
                     pre_actions = upgrade_pre
133 133
 
134 134
                 if not self.disable_update_post and upgrade_post:
135
+                    LOG.warning('Post upgrade actions are ignored by Armada'
136
+                                'and will not affect deployment.')
135 137
                     post_actions = upgrade_post
136 138
 
137 139
             try:

+ 2
- 0
armada/schemas/armada-chart-schema.yaml View File

@@ -146,6 +146,8 @@ data:
146 146
               $ref: '#/definitions/hook_action'
147 147
             create:
148 148
               $ref: '#/definitions/hook_action'
149
+        # TODO(drewwalters96): Armada ignores post-update actions. Remove them
150
+        # in future schemas.
149 151
         post:
150 152
           type: object
151 153
           additionalProperties: false

+ 5
- 14
doc/source/operations/guide-build-armada-yaml.rst View File

@@ -208,35 +208,26 @@ Test options to pass through directly to helm.
208 208
     next upgrade.
209 209
 
210 210
 
211
-Upgrade, Install - Pre or Post
212
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
211
+Upgrade - Pre
212
+^^^^^^^^^^^^^
213 213
 
214 214
 +-------------+----------+---------------------------------------------------------------+
215 215
 | keyword     | type     | action                                                        |
216 216
 +=============+==========+===============================================================+
217
-| pre         | object   | actions prior to updating/installing chart                    |
218
-+-------------+----------+---------------------------------------------------------------+
219
-| post        | object   | actions post updating/installing chart                        |
217
+| pre         | object   | actions performed prior to updating a release                 |
220 218
 +-------------+----------+---------------------------------------------------------------+
221 219
 
222
-
223 220
 Upgrade - Actions
224 221
 ^^^^^^^^^^^^^^^^^
225 222
 
226 223
 +-------------+----------+---------------------------------------------------------------+
227 224
 | keyword     | type     | action                                                        |
228 225
 +=============+==========+===============================================================+
229
-| update      | object   | updates daemonsets in pre update actions                      |
226
+| update      | object   | update daemonsets in pre-upgrade update actions               |
230 227
 +-------------+----------+---------------------------------------------------------------+
231
-| delete      | sequence | delete jobs in pre delete actions and child pods              |
228
+| delete      | sequence | delete jobs and pods in pre-upgrade delete actions            |
232 229
 +-------------+----------+---------------------------------------------------------------+
233 230
 
234
-
235
-.. note::
236
-
237
-    Update actions are performed in the pre/post sections of upgrade
238
-
239
-
240 231
 Upgrade - Actions - Update/Delete
241 232
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
242 233
 

Loading…
Cancel
Save