Fix release name bug

The release name was being treated as multiple different values to
mean the same thing, when paired with the 'release_prefix'.  This
commit addresses the bug, changing all instances to use the
'release' value instead of 'chart_name' or others.

Note: This is an impacting change, in the sense that it will
cause more reliable behavior in Armada's Apply processing which
could have actual impact while upgrading components installed with
a previous version of Armada.  Previuosly undeleted FAILED releases
may now be deleted, and armada test and delete actions may now
run as expected where they didn't run before.

Change-Id: I9893e506274e974cdc8826b1812becf9b89a0ab6
This commit is contained in:
Marshall Margenau
2018-06-14 10:31:52 -05:00
parent 902caee084
commit 52bf21989f
11 changed files with 62 additions and 70 deletions

View File

@@ -23,7 +23,7 @@ from armada.common import policy
from armada import const
from armada.handlers.tiller import Tiller
from armada.handlers.manifest import Manifest
from armada.utils.release import release_prefix
from armada.utils.release import release_prefixer
from armada.utils import validate
CONF = cfg.CONF
@@ -169,8 +169,8 @@ class TestReleasesManifestController(api.BaseResource):
for group in armada_obj.get(const.KEYWORD_ARMADA).get(
const.KEYWORD_GROUPS):
for ch in group.get(const.KEYWORD_CHARTS):
release_name = release_prefix(
prefix, ch.get('chart').get('chart_name'))
release_name = release_prefixer(
prefix, ch.get('chart').get('release'))
if release_name in known_releases:
self.logger.info('RUNNING: %s tests', release_name)