airship/armada
Code Issues Proposed changes

Fix release name bug

Browse Source 
The release name was being treated as multiple different values to
mean the same thing, when paired with the 'release_prefix'.  This
commit addresses the bug, changing all instances to use the
'release' value instead of 'chart_name' or others.

Note: This is an impacting change, in the sense that it will
cause more reliable behavior in Armada's Apply processing which
could have actual impact while upgrading components installed with
a previous version of Armada.  Previuosly undeleted FAILED releases
may now be deleted, and armada test and delete actions may now
run as expected where they didn't run before.

Change-Id: I9893e506274e974cdc8826b1812becf9b89a0ab6
This commit is contained in:
Marshall Margenau
2018-06-14 10:31:52 -05:00
parent 902caee084
commit 52bf21989f
11 changed files with 62 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/commands/apply.rst
View File

@@ -24,7 +24,7 @@ Commands
To override a specific value in a Manifest, run:
$ armada apply examples/simple.yaml --set manifest:simple-armada:release_name="wordpress"
$ armada apply examples/simple.yaml --set manifest:simple-armada:release="wordpress"
Or to override several values in a Manifest, reference a values.yaml-
formatted file:

10
doc/source/operations/guide-build-armada-yaml.rst
View File

@@ -89,7 +89,7 @@ Chart
+=================+==========+=======================================================================================+
| chart\_name | string | name for the chart |
+-----------------+----------+---------------------------------------------------------------------------------------+
| release\_name | string | name of the release |
| release | string | name of the release (Armada will prepend with ``release-prefix`` during processing) |
+-----------------+----------+---------------------------------------------------------------------------------------+
| namespace | string | namespace of your chart |
+-----------------+----------+---------------------------------------------------------------------------------------+
@@ -172,7 +172,7 @@ Chart Example
name: blog-1
data:
chart_name: blog-1
release_name: blog-1
release: blog-1
namespace: default
wait:
timeout: 100
@@ -232,7 +232,7 @@ Source Example
name: blog-1
data:
chart_name: blog-1
release_name: blog-1
release: blog-1
namespace: default
wait:
timeout: 100
@@ -258,7 +258,7 @@ Source Example
name: blog-1
data:
chart_name: blog-1
release_name: blog-1
release: blog-1
namespace: default
wait:
timeout: 100
@@ -282,7 +282,7 @@ Source Example
name: blog-1
data:
chart_name: blog-1
release_name: blog-1
release: blog-1
namespace: default
wait:
timeout: 100