airship/armada
Code Issues Proposed changes

Remove duplicate option certfile from Armada config

Browse Source 
This removes duplicate option certfile from
Armada config causing:

2018-06-13 16:44:42.093 24 ERROR armada   File "/usr/local/lib/python3.5/site-packages/oslo_config/cfg.py", line 801, in _is_opt_registered
2018-06-13 16:44:42.093 24 ERROR armada     raise DuplicateOptError(opt.name)
2018-06-13 16:44:42.093 24 ERROR armada oslo_config.cfg.DuplicateOptError: duplicate option: certfile
2018-06-13 16:44:42.093 24 ERROR armada

This appears to because authtoken Keystone middleware
automatically adds Keystone session options to Armada's
CONF automatically [0]. Thus including
`ks_loading.register_session_conf_options` causes option
duplication.

However, I still don't understand where auth options are set
automatically by other services, which is why
`ks_loading.register_auth_conf_options` is left in the code
(which adds yet other options related to Keystone auth
plugin options, required for creating a Keystone session).

[0] https://docs.openstack.org/keystonemiddleware/latest/middlewarearchitecture.html#configuration

Change-Id: I2c2576c35d87a7b0e3c96ad64fcd88ce54fff86b
This commit is contained in:
Felipe Monteiro
2018-06-13 19:35:25 +01:00
parent 3e129745b4
commit bb8c77bfe1
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
armada/conf/default.py
View File

@@ -95,7 +95,6 @@ path to the private key that includes the name of the key itself.""")),
def register_opts(conf):
conf.register_opts(default_options)
ks_loading.register_auth_conf_options(conf, group='keystone_authtoken')
ks_loading.register_session_conf_options(conf, group='keystone_authtoken')
def list_opts():