Update patch set 20

Patch Set 20:

(5 comments)

Patch-set: 20

7b6d6ab754698dce24e6e84520e8e88e541aea29

@@ -23,6 +23,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "d051096e_5d574cfe",
+        "filename": "charts/tekton-dashboard/templates/deployment-dashboard.yaml",
+        "patchSetId": 19
+      },
+      "lineNbr": 50,
+      "author": {
+        "id": 20466
+      },
+      "writtenOn": "2021-03-26T15:51:37Z",
+      "side": 1,
+      "message": "This name was something left behind and is actually not needed. This looks to be removed from the upstream tekton manifest. Will remove",
+      "parentUuid": "b84931e3_f484ac53",
+      "range": {
+        "startLine": 50,
+        "startChar": 20,
+        "endLine": 50,
+        "endChar": 23
+      },
+      "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "11fb9293_83cd43f4",
@@ -46,6 +70,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "64360e51_f075277d",
+        "filename": "charts/tekton-dashboard/templates/deployment-dashboard.yaml",
+        "patchSetId": 19
+      },
+      "lineNbr": 51,
+      "author": {
+        "id": 20466
+      },
+      "writtenOn": "2021-03-26T15:51:37Z",
+      "side": 1,
+      "message": "Good catch. Will fix.",
+      "parentUuid": "11fb9293_83cd43f4",
+      "range": {
+        "startLine": 51,
+        "startChar": 29,
+        "endLine": 51,
+        "endChar": 33
+      },
+      "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "b440db7c_3dc726bb",
@@ -69,6 +117,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "cf2bef0c_7a92ac8a",
+        "filename": "charts/tekton-dashboard/templates/service-dashboard.yaml",
+        "patchSetId": 19
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 20466
+      },
+      "writtenOn": "2021-03-26T15:51:37Z",
+      "side": 1,
+      "message": "This was lifted from the upstream harbor manifests. I tried not to change much with this as these tekton helm charts will go away (hopefully) one day and be replaced by tekton operators.",
+      "parentUuid": "b440db7c_3dc726bb",
+      "range": {
+        "startLine": 14,
+        "startChar": 18,
+        "endLine": 14,
+        "endChar": 22
+      },
+      "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "967a50a5_571da1df",
@@ -92,6 +164,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "ad720e2c_5626bdcb",
+        "filename": "charts/tekton-pipelines/templates/crds/customresourcedefinition-clustertasks.yaml",
+        "patchSetId": 19
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 20466
+      },
+      "writtenOn": "2021-03-26T15:51:37Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "967a50a5_571da1df",
+      "range": {
+        "startLine": 33,
+        "startChar": 8,
+        "endLine": 33,
+        "endChar": 14
+      },
+      "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5742c4c1_79ab3290",
@@ -114,6 +210,30 @@
       "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "93fafb75_ae9e7496",
+        "filename": "charts/tekton-triggers/templates/deployment-webhook.yaml",
+        "patchSetId": 19
+      },
+      "lineNbr": 49,
+      "author": {
+        "id": 20466
+      },
+      "writtenOn": "2021-03-26T15:51:37Z",
+      "side": 1,
+      "message": "This does not expose a service that has a targetport. Naming it targetport without a port may be confusing.",
+      "parentUuid": "5742c4c1_79ab3290",
+      "range": {
+        "startLine": 49,
+        "startChar": 74,
+        "endLine": 49,
+        "endChar": 79
+      },
+      "revId": "7b6d6ab754698dce24e6e84520e8e88e541aea29",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
     }
   ]
 }