airship/deckhand
Code Issues Proposed changes

ValidationPolicy integration with Validations API

Browse Source 
This PS integrates ValidationPolicy logic with the
Deckhand Validations API.

Support for multiple ValidationPolicy documents is
included.

If a ValidationPolicy is found, then the validations
contained therein are used to determine whether
a revision is successful or not. For example,
if a VP contains 'promenade-schema-validation' then
DH will return success if the externally registered
validation result for that validation is success.
However, if the result was never registered in DH
then the returned result is 'failure'.

In addition, if "extra" validations are registered
(that is validations not present in any VP) then
they are effectively ignored. An error message is
added with enough details to indicate why the validation
is ignored.

This PS adds unit tests to verify the correct behavior
for the above scenarios.

Functional tests and documentation changes will be added
in a follow up once design is ironed out.

Change-Id: I44c657974589ea3563e0a23ad667894329048b46
This commit is contained in:
Felipe Monteiro
2018-02-13 23:34:40 +00:00
committed by Scott Hussey
parent 65c459d1f9
commit d82d0cfaf7
3 changed files with 440 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/testing.rst
View File

@@ -45,7 +45,7 @@ variable via ``PIFPAF_URL`` which is referenced by Deckhand's unit test suite.
Overview
--------
Unit testing currently uses an in-memory sqlite SQLite. Since Deckhand's
Unit testing currently uses an in-memory SQLite database. Since Deckhand's
primary function is to serve as the back-end storage for UCP, the majority
of unit tests perform actual database operations. Mocking is used sparingly
because Deckhand is a fairly insular application that lives at the bottom