b80df59d11
1. There is no exception called `InvalidRollback` in Deckhand (it was removed a while back). Instead, the only exception that db_api.revision_rollback raises is RevisionNotFound from the revision_get call internally. So catch that instead from the controller. 2. The default value of parameters is `str` so when revision_id of '0' is passed to the db module for processing, it skips over the check for `if revision_id == 0` as revision_id is a str, not int. So this leverages builtin int converter logic in falcon [0] but requires uplifting the version of falcon to at least 1.3.0 to make use of it [1]. [0] https://falcon.readthedocs.io/en/stable/api/routing.html#field-converters [1] https://falcon.readthedocs.io/en/1.3.0/api/routing.html#field-converters Change-Id: I068cd9e9b6818a5d51501f2718ee2d40d556c094
57 lines
2.1 KiB
Python
57 lines
2.1 KiB
Python
# Copyright 2017 AT&T Intellectual Property. All other rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import falcon
|
|
from oslo_log import log as logging
|
|
from oslo_utils import excutils
|
|
|
|
from deckhand.control import base as api_base
|
|
from deckhand.control.views import revision as revision_view
|
|
from deckhand.db.sqlalchemy import api as db_api
|
|
from deckhand import errors
|
|
from deckhand import policy
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class RollbackResource(api_base.BaseResource):
|
|
"""API resource for realizing revision rollback."""
|
|
|
|
view_builder = revision_view.ViewBuilder()
|
|
|
|
@policy.authorize('deckhand:create_cleartext_documents')
|
|
def on_post(self, req, resp, revision_id):
|
|
try:
|
|
latest_revision = db_api.revision_get_latest()
|
|
except errors.RevisionNotFound as e:
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.exception(e.format_message())
|
|
|
|
for document in latest_revision['documents']:
|
|
if document['metadata'].get('storagePolicy') == 'encrypted':
|
|
policy.conditional_authorize(
|
|
'deckhand:create_encrypted_documents', req.context)
|
|
break
|
|
|
|
try:
|
|
rollback_revision = db_api.revision_rollback(
|
|
revision_id, latest_revision)
|
|
except errors.RevisionNotFound as e:
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.exception(e.format_message())
|
|
|
|
revision_resp = self.view_builder.show(rollback_revision)
|
|
resp.status = falcon.HTTP_201
|
|
resp.body = revision_resp
|