diff --git a/Makefile b/Makefile index 7cc6e52..d4020a4 100644 --- a/Makefile +++ b/Makefile @@ -12,7 +12,8 @@ DOCKER_IMAGE_TAG ?= latest DOCKER_IMAGE ?= $(DOCKER_REGISTRY)/$(DOCKER_IMAGE_PREFIX)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_TAG) # proxy options -PROXY ?= http://proxy.foo.com:8000 +HTTP_PROXY ?= http://proxy.foo.com:8000 +HTTPS_PROXY ?= http://proxy.foo.com:8000 NO_PROXY ?= localhost,127.0.0.1,.svc.cluster.local USE_PROXY ?= false @@ -24,10 +25,10 @@ PUBLISH ?= false images: ifeq ($(USE_PROXY), true) @docker build . --tag $(DOCKER_IMAGE) \ - --build-arg http_proxy=$(PROXY) \ - --build-arg https_proxy=$(PROXY) \ - --build-arg HTTP_PROXY=$(PROXY) \ - --build-arg HTTPS_PROXY=$(PROXY) \ + --build-arg http_proxy=$(HTTP_PROXY) \ + --build-arg https_proxy=$(HTTPS_PROXY) \ + --build-arg HTTP_PROXY=$(HTTP_PROXY) \ + --build-arg HTTPS_PROXY=$(HTTPS_PROXY) \ --build-arg no_proxy=$(NO_PROXY) \ --build-arg NO_PROXY=$(NO_PROXY) \ --force-rm=$(DOCKER_FORCE_CLEAN) diff --git a/playbooks/airship-hostconfig-operator-build-images.yaml b/playbooks/airship-hostconfig-operator-build-images.yaml index dcb021f..b8bf678 100644 --- a/playbooks/airship-hostconfig-operator-build-images.yaml +++ b/playbooks/airship-hostconfig-operator-build-images.yaml @@ -13,5 +13,5 @@ - hosts: all become: yes roles: - - role: ensure-docker + - role: docker-install - hostconfig-operator-build-images diff --git a/playbooks/airship-hostconfig-operator-publish-images.yaml b/playbooks/airship-hostconfig-operator-publish-images.yaml index bd6d11a..5cb1814 100644 --- a/playbooks/airship-hostconfig-operator-publish-images.yaml +++ b/playbooks/airship-hostconfig-operator-publish-images.yaml @@ -13,5 +13,5 @@ - hosts: all become: yes roles: - - ensure-docker + - docker-install - hostconfig-operator-publish-images diff --git a/roles/airship-gather-runtime-logs/tasks/main.yaml b/roles/airship-gather-runtime-logs/tasks/main.yaml index c13e33d..dc8d679 100644 --- a/roles/airship-gather-runtime-logs/tasks/main.yaml +++ b/roles/airship-gather-runtime-logs/tasks/main.yaml @@ -43,3 +43,6 @@ src: "{{ runtime_logs_dir }}" dest: "{{ zuul.executor.log_root }}/{{ inventory_hostname }}" mode: pull + verify_host: true + owner: no + group: no diff --git a/roles/hostconfig-operator-build-images/tasks/main.yaml b/roles/hostconfig-operator-build-images/tasks/main.yaml index 1c81881..8afd37e 100644 --- a/roles/hostconfig-operator-build-images/tasks/main.yaml +++ b/roles/hostconfig-operator-build-images/tasks/main.yaml @@ -14,8 +14,16 @@ make: chdir: "{{ zuul.project.src_dir }}" target: images + params: + DOCKER_REGISTRY: "{{ image_repo }}" + DOCKER_IMAGE_PREFIX: "{{ docker_image_prefix }}" + USE_PROXY: "{{ proxy.enabled | lower }}" + HTTP_PROXY: "{{ proxy.http }}" + HTTPS_PROXY: "{{ proxy.https }}" + DOCKER_IMAGE_TAG: "{{ zuul.change | default('latest') }}" + NO_PROXY: "{{ proxy.noproxy }}" - name: Verify Image Exists - shell: docker image inspect "$(make print-docker-image-tag)" + shell: docker image inspect "$(make DOCKER_REGISTRY={{ image_repo }} DOCKER_IMAGE_PREFIX={{ docker_image_prefix }} DOCKER_IMAGE_TAG={{ zuul.change | default('latest') }} print-docker-image-tag)" args: chdir: "{{ zuul.project.src_dir }}" diff --git a/roles/hostconfig-operator-publish-images/tasks/main.yaml b/roles/hostconfig-operator-publish-images/tasks/main.yaml index 6983941..055e057 100644 --- a/roles/hostconfig-operator-publish-images/tasks/main.yaml +++ b/roles/hostconfig-operator-publish-images/tasks/main.yaml @@ -32,8 +32,13 @@ make: chdir: "{{ zuul.project.src_dir }}" params: + USE_PROXY: "{{ proxy.enabled | lower }}" + HTTP_PROXY: "{{ proxy.http }}" + HTTPS_PROXY: "{{ proxy.https }}" + NO_PROXY: "{{ proxy.noproxy }}" DOCKER_IMAGE_TAG: latest DOCKER_REGISTRY: "{{ image_repo }}" + DOCKER_IMAGE_PREFIX: "{{ docker_image_prefix }}" PUBLISH: "true" target: images @@ -41,7 +46,12 @@ make: chdir: "{{ zuul.project.src_dir }}" params: + USE_PROXY: "{{ proxy.enabled | lower }}" + HTTP_PROXY: "{{ proxy.http }}" + HTTPS_PROXY: "{{ proxy.https }}" + NO_PROXY: "{{ proxy.noproxy }}" DOCKER_IMAGE_TAG: "{{ zuul.newrev }}" DOCKER_REGISTRY: "{{ image_repo }}" + DOCKER_IMAGE_PREFIX: "{{ docker_image_prefix }}" PUBLISH: "true" target: images diff --git a/zuul.d/jobs.yaml b/zuul.d/jobs.yaml index 4182813..a76e609 100644 --- a/zuul.d/jobs.yaml +++ b/zuul.d/jobs.yaml @@ -53,9 +53,6 @@ - name: hostconfig_operator_image_repo_credentials secret: hostconfig_operator_image_repo_credentials pass-to-parent: true - vars: - image: quay.io/airshipit/hostconfig-operator - image_repo: quay.io - job: name: airship-hostconfig-operator-upload-git-mirror diff --git a/zuul.d/projects.yaml b/zuul.d/projects.yaml index 30e450c..0a7c1be 100644 --- a/zuul.d/projects.yaml +++ b/zuul.d/projects.yaml @@ -11,6 +11,15 @@ # limitations under the License. - project: + vars: + proxy: + enabled: false + http: "" + https: "" + noproxy: "" + image_repo: quay.io + docker_image_prefix: airshipit + check: jobs: - airship-hostconfig-operator-test