From 2e4afa5914438fd040bd790eb3849bbf5459af50 Mon Sep 17 00:00:00 2001 From: Gerrit User 32167 <32167@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Sun, 30 May 2021 14:57:48 +0000 Subject: [PATCH] Update patch set 9 Patch Set 9: Code-Review-1 (1 comment) I think changing the docker.sock permissions will not be a good idea. Patch-set: 9 Reviewer: Gerrit User 32167 <32167@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 --- c9d6ca16ffe63da25f586d4e565bcead90415e78 | 27 ++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 c9d6ca16ffe63da25f586d4e565bcead90415e78 diff --git a/c9d6ca16ffe63da25f586d4e565bcead90415e78 b/c9d6ca16ffe63da25f586d4e565bcead90415e78 new file mode 100644 index 0000000..77b9b28 --- /dev/null +++ b/c9d6ca16ffe63da25f586d4e565bcead90415e78 @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "key": { + "uuid": "3a9d84cf_d2ef2faf", + "filename": "tools/deployment/00_install_prerequsite.sh", + "patchSetId": 9 + }, + "lineNbr": 74, + "author": { + "id": 32167 + }, + "writtenOn": "2021-05-30T14:57:48Z", + "side": 1, + "message": "This forces the ownership to current user, I think this wouldn\u0027t be a better idea if a developer runs it locally on his system. May be we can just reset the connection and update the user in config.yaml file. https://review.opendev.org/c/airship/hostconfig-operator/+/793694\nAnd then update the readme doc to re-login after the user executes the 00_install_prerequisite.sh script to load the docker group.", + "range": { + "startLine": 70, + "startChar": 0, + "endLine": 74, + "endChar": 0 + }, + "revId": "c9d6ca16ffe63da25f586d4e565bcead90415e78", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + } + ] +} \ No newline at end of file