HUGHES, ALEXANDER (ah8742)
a8620cfd8d
Some secrets are being created with undesirable permissions. Upon
inspection it was noticed that in general Pegleg is creating files,
then changing permissions after the fact. This leads to a small
window where the permissions on a file are overly permissive.
This patchset:
1. Sets default umask of 0o027 (640 permissions for files)
2. Explicitly adds the open flag ('r', 'w' etc.) to all open() calls.
3. Replaces sys.stdout.write calls with click.echo() calls to be more
in line with the rest of the project.
4. Re-orders methods that write so that data is always first, and the
path is always second.
5. Updates unit tests.
6. Adds unit tests for testing directory and file permissions.
7. Minor style changes.
Change-Id: I0c154aa311ea371940fd24b0aabf58fffaf1d231
42 lines
1.3 KiB
Python
42 lines
1.3 KiB
Python
# Copyright 2018 AT&T Intellectual Property. All other rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import logging
|
|
|
|
import click
|
|
from prettytable import PrettyTable
|
|
|
|
from pegleg.engine import util
|
|
from pegleg.engine.util import files
|
|
|
|
__all__ = ('list_types', )
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
def list_types(output_stream):
|
|
"""List type names for a given repository."""
|
|
|
|
# Create a table to output site types for a given repo
|
|
type_table = PrettyTable()
|
|
type_table.field_names = ['type_name']
|
|
for type_name in util.files.list_types():
|
|
type_table.add_row([type_name])
|
|
# Write table to specified output_stream
|
|
msg = type_table.get_string()
|
|
if output_stream:
|
|
files.write(msg + "\n", output_stream)
|
|
else:
|
|
click.echo(msg)
|