airship/promenade
Code Issues Proposed changes

Remove kubelet restart from join.sh

Browse Source 
The kubelet restart at the end of the join script appears
to be unnecessary, since the only action taken by the script
between that and the previous kubelet start is node labelling
(which doesn't require a kubelet restart).

In addition, the timing of this restart may be triggering
a kubernetes state synchronization bug, where a pod's status
isn't updated to reflect the readiness of all of its containers.

Change-Id: I480d1b345e5ddcce0cac961ff9c2b76526c5b76f
This commit is contained in:
Matt McEuen 2020-01-13 22:46:50 -06:00
parent fe29812aca
commit 153882b153
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
promenade/templates/scripts/join.sh
View File

@ -33,8 +33,6 @@ register_labels {{ config['KubernetesNode:hostname'] }} 3600 {{ config['Kubernet
sleep 60 sleep 60
{% include "cleanup.sh" with context %}
set +x set +x
log log
log === Finished join process === log === Finished join process ===