airship/shipyard
Code Issues Proposed changes

Change message when no nodes found during update

Browse Source 
Updates the message when no nodes are found during an update_site
action. This safeguard doesn't change behavior from the previous
implementation, but improves the contextual clues for the consumer of
the messages produced.

Includes general reformatting and improvement of the logging text
throughout the same module.

Change-Id: I4ce6ed8da14836a33c53fd6d16805789de19ed9a
This commit is contained in:
Bryan Strassner 2019-02-08 17:19:35 -06:00
parent f4f57a1bbf
commit 17d7f273a2
1 changed files with 38 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/bin/shipyard_airflow/shipyard_airflow/plugins/drydock_verify_nodes.py
View File

@ -23,37 +23,57 @@ except ImportError:
DrydockBaseOperator DrydockBaseOperator
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
safeguard_message_header = (
"No nodes were found by Drydock. Safeguard triggered to prevent "
"continued deployment of nodes.")
safeguard_message_body = (
"This condition can occur if update_site is invoked before a deploy_site "
"has previously deployed nodes in this site. If nodes are expected to be "
"present (previously deployed), this is a serious condition and should "
"be investigated. This behavior can be bypassed by setting "
"continue-on-fail to true.")
safeguard_bypassed_message = (
"Nodes do not exist, but continue-on-fail is True. Safeguard bypassed by "
"invocation options.")
class DrydockVerifyNodesExistOperator(DrydockBaseOperator): class DrydockVerifyNodesExistOperator(DrydockBaseOperator):
"""Drydock Verify nodes exist Operator """Drydock Verify nodes exist Operator
This operator will trigger drydock to verify node for Check that ANY nodes exist.
site update One use of this is to prevent an update_site from redeploying servers if
the underlying datastores have lost their data. Doing this prevents
destruction of potentially running workloads.
""" """
def do_execute(self): def do_execute(self):
LOG.info("Verifying that nodes exist before proceeding.")
LOG.info('verify_nodes_exit was invoked.')
node_list = self.get_nodes() node_list = self.get_nodes()
continue_on_fail = self.action_info['parameters'].get( if not node_list:
'continue-on-fail', 'false') if self.continue_on_fail():
LOG.debug('node list is : {}'.format(node_list)) LOG.info(safeguard_bypassed_message)
LOG.debug('continue on fail is: {}'.format(continue_on_fail)) else:
LOG.error(safeguard_message_header)
LOG.error(safeguard_message_body)
raise AirflowException(safeguard_message_header)
else:
LOG.info("Drydock reports nodes: %s", node_list)
if not node_list and str(continue_on_fail).lower() != 'true': def continue_on_fail(self):
msg = 'No nodes were found in MaaS, ' \ """Retrieve the continue_on_fail boolean value
'and continue_on_fail is {} ' \
'-> Fail Drydock prepare and ' \ Fetch the continue-on-fail value from the action_info parameters and
'deply nodes.'.format(continue_on_fail) translate it into a boolean value.
LOG.error(msg) """
raise AirflowException(msg) continue_on_fail_str = str(self.action_info['parameters'].get(
'continue-on-fail', 'false'))
continue_on_fail = continue_on_fail_str.lower() == 'true'
LOG.debug("continue-on-fail value is: %s, evaluates to: %s",
continue_on_fail_str, continue_on_fail)
return continue_on_fail
class DrydockVerifyNodesExistOperatorPlugin(AirflowPlugin): class DrydockVerifyNodesExistOperatorPlugin(AirflowPlugin):
"""Creates DrydockVerifyNodesExistOperatorPlugin in Airflow.""" """Creates DrydockVerifyNodesExistOperatorPlugin in Airflow."""
name = 'drydock_verify_nodes_exist_operator' name = 'drydock_verify_nodes_exist_operator'