airship
/
shipyard
Code Issues Proposed changes

Update Airflow/Shipyard Dockerfile 

As mentioned in [0], the best practice is NOT to use ENV for
DEBIAN_FRONTEND as it will persists in the final image. It
appears that the common consensus is to use ARG instead so
that noninteractive DEBIAN_FRONTEND is set only during build.

[0] https://github.com/moby/moby/issues/4032

Change-Id: I6980e140ee5a51596a2f9ba4e1471e2c98599846
This commit is contained in:
Anthony Lin 2018-04-12 17:11:56 +00:00 committed by Bryan Strassner
parent a51e30f0a2
commit 31b4dc373f
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
images/airflow/Dockerfile
View File

@ -19,7 +19,6 @@ FROM ubuntu:16.04
# Set port 8080 for Airflow Web
# Set port 5555 for Airflow Flower
# Set port 8793 for Airflow Worker
ENV DEBIAN_FRONTEND noninteractive
ENV container docker
ENV WEB_PORT 8080
ENV FLOWER_PORT 5555
@ -30,8 +29,9 @@ EXPOSE $WEB_PORT
EXPOSE $FLOWER_PORT
EXPOSE $WORKER_PORT
# Airflow Home Directory
# Set ARG for usage during build
ARG AIRFLOW_HOME=/usr/local/airflow
ARG DEBIAN_FRONTEND=noninteractive
# Kubectl version
ARG KUBECTL_VERSION=1.8.6

3
images/shipyard/Dockerfile
View File

@ -14,12 +14,13 @@
FROM python:3.5
ENV DEBIAN_FRONTEND noninteractive
ENV container docker
ENV PORT 9000
ENV LC_ALL C.UTF-8
ENV LANG C.UTF-8
ARG DEBIAN_FRONTEND=noninteractive
# Expose port 9000 for application
EXPOSE $PORT