Update patch set 2

Patch Set 2: Code-Review-1 (5 comments) Patch-set: 2 Reviewer: Gerrit User 23186 <23186@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2018-06-26 14:04:14 +00:00 · 2018-06-26 14:04:14 +00:00 · 7317d1243f
parent 39072a560b
commit 7317d1243f
1 changed files with 95 additions and 0 deletions
--- a/95
+++ b/95
@ -0,0 +1,95 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5f7c97a3_9ab04dde",
+        "filename": "images/shipyard/Dockerfile",
+        "patchSetId": 2
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 23186
+      },
+      "writtenOn": "2018-06-26T14:04:14Z",
+      "side": 1,
+      "message": "We should add a comment here saying this will need to be Python 3 at the very least as Shipyard is incompatible with Python 2.",
+      "revId": "6c7ea2764fdf5242d22278a10bc7f3cf2fb7ba04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_7ab1b100",
+        "filename": "tools/gate/roles/build-images/files/docker-systemd.conf",
+        "patchSetId": 2
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 23186
+      },
+      "writtenOn": "2018-06-26T14:04:14Z",
+      "side": 1,
+      "message": "s/build/built",
+      "revId": "6c7ea2764fdf5242d22278a10bc7f3cf2fb7ba04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_5a787529",
+        "filename": "tools/gate/roles/build-images/tasks/airship-shipyard.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 62,
+      "author": {
+        "id": 23186
+      },
+      "writtenOn": "2018-06-26T14:04:14Z",
+      "side": 1,
+      "message": "Why not move this to L40 (above block) if this applies to the entire task?",
+      "range": {
+        "startLine": 62,
+        "startChar": 6,
+        "endLine": 62,
+        "endChar": 41
+      },
+      "revId": "6c7ea2764fdf5242d22278a10bc7f3cf2fb7ba04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_fa72a149",
+        "filename": "tools/gate/roles/build-images/tasks/airship-shipyard.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 65,
+      "author": {
+        "id": 23186
+      },
+      "writtenOn": "2018-06-26T14:04:14Z",
+      "side": 1,
+      "message": "Ditto",
+      "revId": "6c7ea2764fdf5242d22278a10bc7f3cf2fb7ba04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_ba8e6924",
+        "filename": "tools/gate/roles/build-images/tasks/airship-shipyard.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 72,
+      "author": {
+        "id": 23186
+      },
+      "writtenOn": "2018-06-26T14:04:14Z",
+      "side": 1,
+      "message": "Ditto",
+      "revId": "6c7ea2764fdf5242d22278a10bc7f3cf2fb7ba04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}