airship/shipyard
Code Issues Proposed changes

Update Drydock Operator

Browse Source 
The bug [0] in DryDock has been fixed.

This P.S. is meant to remove the temporary workaround that
was put in place earlier.

[0]: https://github.com/att-comdev/drydock/issues/73

Change-Id: I32e6b4b35b1e1d2c55113aaff95a9c3ea6fbe666
This commit is contained in:
Anthony Lin
2017-12-20 08:30:52 +00:00
parent dcc6c3fb6e
commit e1929b358d
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
shipyard_airflow/plugins/drydock_operators.py
View File

@@ -314,12 +314,15 @@ class DryDockOperator(BaseOperator):
time.sleep(int(interval))
# Get final task result
# NOTE: There is a known bug in Drydock where the task result
# for a successfully completed task can either be 'success',
# 'partial success' or 'incomplete'. This will be fixed in Drydock
# in the near future. Updates will be made to the Drydock Operator
# once the bug is fixed.
if task_result in ['success', 'partial_success', 'incomplete']:
# NOTE: The promenade join script does not have a call-back step
# to indicate that the process is completed at the moment. This
# will lead to Drydock returning 'partial success' at the end of
# the 'deploy_nodes' task as it times out while waiting for the
# response from promenade (bootactions will fail as a result). As
# such, we are keeping 'partial_success' as a valid task result
# for now and will update the Drydock Operator once the promenade
# feature is ready for consumption.
if task_result in ['success', 'partial_success']:
logging.info('Task id %s has been successfully completed',
self.task_id)
else: