Set ULID of action on DAG request

Sets the run_id for a DAG invoked in Airflow to the same ULID assigned
to it in Shipyard. While this was already happening as a parameter to
the DAG being invoked, by making it the run_id, further correlation is
possible, at a level that both Shipyard and the Airflow framework are
aware.

As part of making this change, fragility was uncovered in the
rest_api_plugin that expedited the need to switch to the built-in, but
experimental airflow API to trigger a dag (one of two API endpoints
provided - this is important later in this story). In any case, the 3rd
party rest_api_plugin was removed.

As a result of the rest_api_plugin being removed:
1) the simpleton helm test to check the api of airflow was also removed
(it used the version endpoint of this plugin). As the built-in api
provides no version endpoint or similarly accessible-without-being-stateful
endpoint, the helm test had no new place to look for something to call.
2) Some clean up of exclusions and documentation was possible - test
coverage, security exclusions, left over documentation remnants

Change-Id: I0b68496a8500408b776b4acc12888aa017c4c7d2

charts/shipyard/templates/tests/test-airflow-api.yaml

@@ -1,42 +0,0 @@
-{{/*
-# Copyright (c) 2018 AT&T Intellectual Property. All rights reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-*/}}
-{{/*
-Test Airflow for api functionality.
-*/}}
-{{- if .Values.manifests.test_airflow_api }}
-{{- $envAll := . }}
----
-apiVersion: v1
-kind: Pod
-metadata:
-  name: "{{ .Release.Name }}-airflow-api-test"
-  annotations:
-    "helm.sh/hook": "test-success"
-  labels:
-{{ tuple $envAll "airflow" "api-test" | include "helm-toolkit.snippets.kubernetes_metadata_labels" | indent 4 }}
-spec:
-  restartPolicy: Never
-  containers:
-    - name: "{{ .Release.Name }}-airflow-api-test"
-      env:
-        - name: 'AIRFLOW_URL'
-          value: {{ tuple "airflow_web" "internal" "airflow_web" . | include "helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup" | quote }}
-      image: {{ .Values.images.tags.airflow }}
-      imagePullPolicy: {{ .Values.images.pull_policy }}
-{{ tuple . .Values.pod.resources.test.airflow | include "helm-toolkit.snippets.kubernetes_resources" | indent 6 }}
-      command: ["/bin/bash", "-c", "curl -v -X GET --fail ${AIRFLOW_URL}/admin/rest_api/api?api=version; exit $?"]
-...
-{{- end }}

charts/shipyard/values.yaml

@@ -727,4 +727,3 @@ manifests:
   service_airflow_worker: true
   service_discovery_airflow_worker: true
   test_shipyard_api: true
-  test_airflow_api: true