shipyard/src/bin/shipyard_airflow/shipyard_airflow/plugins/armada_validate_design.py
Andrey Volkov 4164518502 Ensure pod logs are fetched in case of exception in any operator
This patch tries to cover some edge cases could happen during Shipyard
Airflow operator execution. All operators at the moment make
interactions with other services i.e. k8s pods. In a case of exceptions
during execution of the operator, logs will be fetched from the
appropriate pod and if the operator has "fetch_failure_details" method
(see DrydockBaseOperator) it will be called as well.

What exception could happen during an operator execution?
Besides explicitly defined in code like
DrydockClientUseFailureException, other exception e.g. KeyError or
similar may be raised. It's not clear who is a culprit in that client
side (Shipyard) or server side (Drydock, Armada, Deckhand,
Promenade). So this patch applies defensive mode and gets logs from
pods and gets additional details for any exceptional situations.

For doing that do_execute method is wrapped with try..except
in UcpBaseOperator.execute. While fetching logs from a pod
and fetching failure details it makes appropriate logging by itself
and finally reraises the original exception.

Change-Id: If1501e9a24b05edb6eb32c7b1b2d27f24f3ee063
2018-09-19 09:17:13 -07:00

75 lines
2.3 KiB
Python

# Copyright 2018 AT&T Intellectual Property. All other rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import logging
from airflow.plugins_manager import AirflowPlugin
from airflow.exceptions import AirflowException
try:
from armada_base_operator import ArmadaBaseOperator
except ImportError:
from shipyard_airflow.plugins.armada_base_operator import \
ArmadaBaseOperator
from armada.exceptions import api_exceptions as errors
LOG = logging.getLogger(__name__)
class ArmadaValidateDesignOperator(ArmadaBaseOperator):
"""Armada Validate Design Operator
This operator will trigger armada to validate the
site design
"""
def do_execute(self):
# Requests Armada to validate site design
LOG.info("Waiting for Armada to validate site design...")
# Retrieve read timeout
timeout = self.dc['armada.validate_design_timeout']
# Validate Site Design
try:
post_validate = self.armada_client.post_validate(
manifest=self.design_ref, timeout=timeout)
except errors.ClientError as client_error:
raise AirflowException(client_error)
# Print results
LOG.info("Retrieving Armada validate site design response...")
LOG.info(post_validate)
# Check if site design is valid
status = str(post_validate.get('status', 'unspecified'))
if status.lower() == 'success':
LOG.info("Site Design has been successfully validated")
else:
raise AirflowException("Site Design Validation Failed "
"with status: {}!".format(status))
class ArmadaValidateDesignOperatorPlugin(AirflowPlugin):
"""Creates ArmadaValidateDesignOperator in Airflow."""
name = 'armada_validate_design_operator'
operators = [ArmadaValidateDesignOperator]