Update patch set 12

Patch Set 12: (8 comments) Patch-set: 12 Label: Verified=0
2019-09-04 15:07:46 +00:00 · 2019-09-04 15:07:46 +00:00 · 1e4451b4f6
commit 1e4451b4f6
parent f2c789b598
1 changed files with 166 additions and 0 deletions
--- a/166
+++ b/166
@ -1,5 +1,28 @@
 {
  "comments": [
+    {
+      "key": {
+        "uuid": "7faddb67_19055410",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 68,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "There ideally should be no any CLI options, all configuration should be gathered from site YAMLs.",
+      "range": {
+        "startLine": 68,
+        "startChar": 0,
+        "endLine": 68,
+        "endChar": 41
+      },
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
    {
      "key": {
        "uuid": "7faddb67_b8f8c1c3",
@ -22,6 +45,149 @@
      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_59798cf9",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 107,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "Should it be in deckhand format? https://airship-deckhand.readthedocs.io/en/latest/users/index.html",
+      "range": {
+        "startLine": 107,
+        "startChar": 2,
+        "endLine": 107,
+        "endChar": 30
+      },
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_5e3412fb",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 107,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "Could be and extension of ``airshipctl config`` yaml spec.",
+      "range": {
+        "startLine": 107,
+        "startChar": 37,
+        "endLine": 107,
+        "endChar": 60
+      },
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_9e3fea20",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 114,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "boot_image_url:\n    http_remote_url: https://zzz.yy/path/image.iso (required)\n    http_push_login: username (optional)\n    http_push_pass: pass (optional)\n    http_push_authtoken: authtoken (optional)\n    http_pull_login: username (optional)\n    http_pull_pass: pass (optional)",
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_1ea45a06",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 117,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "Only _local_ file:////dst/path/in/container/image.iso",
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_7ee0ee97",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 118,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "Not http link.",
+      "range": {
+        "startLine": 118,
+        "startChar": 10,
+        "endLine": 118,
+        "endChar": 19
+      },
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_7e8eaed1",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 120,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "Remove?",
+      "range": {
+        "startLine": 120,
+        "startChar": 6,
+        "endLine": 120,
+        "endChar": 23
+      },
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_de6ec294",
+        "filename": "specs/approved/airshipctl_bootstrap_image.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 123,
+      "author": {
+        "id": 28208
+      },
+      "writtenOn": "2019-09-04T15:07:46Z",
+      "side": 1,
+      "message": "What else is needed: possibly credentials to push image to http, and credentials to pull image from http url.\n\n  volume: \"/source/path/on/host:/dst/path/in/container:rw\" (required)\n  image: \"image_generator:tag\" (required)\n  container_runtime: \"docker\" (optional, default\u003ddocker)",
+      "revId": "7c222157e3175382ce1a399406f3b9f75f85db1d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
    }
  ]
 }