airship
/
specs
Code Issues Proposed changes

Update patch set 18 

Patch-set: 18
This commit is contained in:
Gerrit User 7185 2019-09-05 16:46:41 +00:00 committed by Gerrit Code Review
parent 7a968c9b90
commit 6f332aa12e
1 changed files with 216 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

216
e2756783ca0896ee07d63b212107af0134fef26c
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_9f9a68c2",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 18,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_f6c94c24",
"range": {
"startLine": 18,
"startChar": 18,
"endLine": 18,
"endChar": 21
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_56daa0e8",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5fa070f3",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 19,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_56daa0e8",
"range": {
"startLine": 19,
"startChar": 14,
"endLine": 19,
"endChar": 23
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_d6ef7084",
@ -69,6 +117,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_7fa3ecff",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 20,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_d6ef7084",
"range": {
"startLine": 20,
"startChar": 28,
"endLine": 20,
"endChar": 31
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_96e578a6",
@ -92,6 +164,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_dfb3004d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 21,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_96e578a6",
"range": {
"startLine": 21,
"startChar": 16,
"endLine": 21,
"endChar": 25
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_969a5810",
@ -115,6 +211,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_ffaefce1",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 39,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_969a5810",
"range": {
"startLine": 39,
"startChar": 10,
"endLine": 39,
"endChar": 15
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_d18e9a25",
@ -138,6 +258,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_7f7c4c70",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 40,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_d18e9a25",
"range": {
"startLine": 40,
"startChar": 67,
"endLine": 40,
"endChar": 74
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b1975e39",
@ -161,6 +305,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_1f975892",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 41,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_b1975e39",
"range": {
"startLine": 41,
"startChar": 35,
"endLine": 41,
"endChar": 42
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b6a3d4fe",
@ -184,6 +352,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_9fd1085a",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 115,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Added example. There is no way to set default value for this since it highly depends on volume bind path which is specified by user",
"parentUuid": "7faddb67_b6a3d4fe",
"range": {
"startLine": 114,
"startChar": 2,
"endLine": 115,
"endChar": 26
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5155ca4e",
@ -206,6 +398,30 @@
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5fc71099",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 18
},
"lineNbr": 120,
"author": {
"id": 7185
},
"writtenOn": "2019-09-05T16:46:41Z",
"side": 1,
"message": "Done",
"parentUuid": "7faddb67_5155ca4e",
"range": {
"startLine": 120,
"startChar": 2,
"endLine": 120,
"endChar": 9
},
"revId": "e2756783ca0896ee07d63b212107af0134fef26c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}