Update patch set 5
Patch Set 5: Code-Review-1 (11 comments) Patch-set: 5 Label: Code-Review=-1
This commit is contained in:
parent
1f5148fc3a
commit
88e3a0ca00
@ -1,5 +1,51 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_5858ae88",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "be built",
|
||||
"range": {
|
||||
"startLine": 38,
|
||||
"startChar": 24,
|
||||
"endLine": 38,
|
||||
"endChar": 36
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_1856b65d",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "and",
|
||||
"range": {
|
||||
"startLine": 42,
|
||||
"startChar": 65,
|
||||
"endLine": 42,
|
||||
"endChar": 66
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_01cdf583",
|
||||
@ -109,6 +155,98 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_b8cc4a35",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 56,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "whitespace",
|
||||
"range": {
|
||||
"startLine": 56,
|
||||
"startChar": 62,
|
||||
"endLine": 56,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_18db16ed",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "# Test",
|
||||
"range": {
|
||||
"startLine": 81,
|
||||
"startChar": 8,
|
||||
"endLine": 81,
|
||||
"endChar": 13
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_f8dde2dc",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 95,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "similar to",
|
||||
"range": {
|
||||
"startLine": 95,
|
||||
"startChar": 25,
|
||||
"endLine": 95,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_58e66eb2",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 95,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "would not",
|
||||
"range": {
|
||||
"startLine": 95,
|
||||
"startChar": 68,
|
||||
"endLine": 95,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_c18b5dbd",
|
||||
@ -126,6 +264,98 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_b89a0a11",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 106,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "used",
|
||||
"range": {
|
||||
"startLine": 106,
|
||||
"startChar": 41,
|
||||
"endLine": 106,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_78a01243",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 109,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "converted to a normal",
|
||||
"range": {
|
||||
"startLine": 109,
|
||||
"startChar": 13,
|
||||
"endLine": 109,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_1889d6c8",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 110,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "an",
|
||||
"range": {
|
||||
"startLine": 110,
|
||||
"startChar": 0,
|
||||
"endLine": 110,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_d88edecf",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 114,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "Unfortunately",
|
||||
"range": {
|
||||
"startLine": 114,
|
||||
"startChar": 0,
|
||||
"endLine": 114,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_9dbcd8dc",
|
||||
@ -149,6 +379,29 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_78b9f276",
|
||||
"filename": "specs/approved/armada_time_metrics.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 117,
|
||||
"author": {
|
||||
"id": 29624
|
||||
},
|
||||
"writtenOn": "2019-06-27T13:46:10Z",
|
||||
"side": 1,
|
||||
"message": "providing",
|
||||
"range": {
|
||||
"startLine": 117,
|
||||
"startChar": 0,
|
||||
"endLine": 117,
|
||||
"endChar": 7
|
||||
},
|
||||
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_1dd0e81e",
|
||||
|
Loading…
Reference in New Issue
Block a user