airship
/
specs
Code Issues Proposed changes

Update patch set 21 

Patch Set 21: Code-Review-1

(4 comments)

Patch-set: 21
Reviewer: Gerrit User 29624 <29624@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 29624 2019-09-11 12:42:35 +00:00 committed by Gerrit Code Review
parent 25a6b95664
commit 8991b19da4
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
e0453343e60fe4edfde6a3d543bf6aa67aea2b1f Normal file
View File

@ -0,0 +1,96 @@
{
"comments": [
{
"key": {
"uuid": "5faad753_86770403",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 86,
"author": {
"id": 29624
},
"writtenOn": "2019-09-11T12:42:35Z",
"side": 1,
"message": "which contain",
"range": {
"startLine": 86,
"startChar": 58,
"endLine": 86,
"endChar": 75
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_66668854",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 114,
"author": {
"id": 29624
},
"writtenOn": "2019-09-11T12:42:35Z",
"side": 1,
"message": "cluster differs",
"range": {
"startLine": 114,
"startChar": 11,
"endLine": 114,
"endChar": 29
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_e6511864",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 192,
"author": {
"id": 29624
},
"writtenOn": "2019-09-11T12:42:35Z",
"side": 1,
"message": "nit: extra space",
"range": {
"startLine": 192,
"startChar": 47,
"endLine": 192,
"endChar": 48
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_26d5f0b9",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 254,
"author": {
"id": 29624
},
"writtenOn": "2019-09-11T12:42:35Z",
"side": 1,
"message": "started",
"range": {
"startLine": 254,
"startChar": 53,
"endLine": 254,
"endChar": 60
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}