diff --git a/66e012f8d52e30ce63d17014a2f8ddec0aa43290 b/66e012f8d52e30ce63d17014a2f8ddec0aa43290 index e071802..2f57e8f 100644 --- a/66e012f8d52e30ce63d17014a2f8ddec0aa43290 +++ b/66e012f8d52e30ce63d17014a2f8ddec0aa43290 @@ -184,6 +184,98 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "bfb3d3c7_403dc4b9", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 60, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "This is in contrast", + "range": { + "startLine": 60, + "startChar": 40, + "endLine": 60, + "endChar": 56 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_e062b8d8", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 61, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "odd line length", + "range": { + "startLine": 61, + "startChar": 42, + "endLine": 61, + "endChar": 44 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_00b58c31", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 70, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "space", + "range": { + "startLine": 70, + "startChar": 30, + "endLine": 70, + "endChar": 33 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_c088d472", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 74, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "f", + "range": { + "startLine": 74, + "startChar": 60, + "endLine": 74, + "endChar": 61 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "bfb3d3c7_a91eeb6d", @@ -253,6 +345,52 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "bfb3d3c7_c02f74f4", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 94, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "Does it make sense to call it as a \"Cluster Context\" or \"Cluster config context\" or \"Site context\"?", + "range": { + "startLine": 94, + "startChar": 0, + "endLine": 94, + "endChar": 8 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_0004ac16", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 116, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "``--airshipconfig`` ?", + "range": { + "startLine": 116, + "startChar": 7, + "endLine": 116, + "endChar": 22 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "bfb3d3c7_845989ff", @@ -414,6 +552,98 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "bfb3d3c7_44a86a1e", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 226, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "Does this mean airshipctl will take care of generation, rotation, encryption and decryption? If yes, then can this be reflected in the options below?", + "range": { + "startLine": 226, + "startChar": 18, + "endLine": 226, + "endChar": 40 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_c471bae2", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 242, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "Slightly confused here. Does this mean airshipctl command will create the secret in the k8s cluster similar to kubectl create secret or is this something different?", + "range": { + "startLine": 242, + "startChar": 2, + "endLine": 242, + "endChar": 60 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_e4307e0a", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 249, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "do we need this option for revision?", + "range": { + "startLine": 249, + "startChar": 39, + "endLine": 249, + "endChar": 56 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "bfb3d3c7_273538db", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 264, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "Should this include ``delete`` or ``Rollback`` option as well?", + "range": { + "startLine": 264, + "startChar": 0, + "endLine": 264, + "endChar": 20 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "bfb3d3c7_8f8e8725", @@ -437,6 +667,29 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "bfb3d3c7_e7e88017", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 3 + }, + "lineNbr": 342, + "author": { + "id": 22259 + }, + "writtenOn": "2019-05-20T04:52:29Z", + "side": 1, + "message": "is this a part of the ``document`` subcommand?", + "range": { + "startLine": 342, + "startChar": 15, + "endLine": 342, + "endChar": 23 + }, + "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "bfb3d3c7_e40965dd",