Update patch set 13
Patch Set 13: Code-Review-1 (11 comments) Patch-set: 13 Reviewer: Gerrit User 22259 <22259@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 22259
Gerrit Code Review
parent
46870c8e99
commit
beb1a1b1bb
@ -86,6 +86,23 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_f27af521",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 119,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "does it make sense to define a generic schema or a layout example of how the config will look like as part of this spec?",
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_d556cd5c",
|
||||
@ -287,6 +304,52 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_56da8c4a",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 238,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "Is this independent of cluster-api concept of creating the bootstrap cluster or there are plans to leverage bootstrap mechanism via clusterctl calls? - https://github.com/kubernetes-sigs/cluster-api/tree/master/cmd/clusterctl#creating-a-cluster",
|
||||
"range": {
|
||||
"startLine": 238,
|
||||
"startChar": 0,
|
||||
"endLine": 238,
|
||||
"endChar": 31
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_f5cdff5c",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 247,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "This can be represented as a codeblock syntax \"::\"",
|
||||
"range": {
|
||||
"startLine": 245,
|
||||
"startChar": 8,
|
||||
"endLine": 247,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_6baf19e3",
|
||||
@ -333,6 +396,52 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_89146c4e",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 290,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "How do we ensure that these are the only set of CR\u0027s that get delivered to the bootstrap cluster as in the config we are pointing to the complete site repository which would contain all the documents for a site. \n\nShould there be a different ``config set-repository`` for different phases in the deployment? for eg: prior to running ``bootstrap init`` we need to set config or clone documents only related to bootstrap? If yes then it can be clarified in the spec.",
|
||||
"range": {
|
||||
"startLine": 283,
|
||||
"startChar": 0,
|
||||
"endLine": 290,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_cd9b4f70",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 294,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "- Where would this yaml definition live? \n- how will ``airshipctl`` know to use this yaml definition as part of this command? do we pass the yaml definition as a flag, whether it reads from the config file?\n- what would be the contents of the yaml definiton? can we have example layout or schema at a high level with the contents of this file as part of the spec.",
|
||||
"range": {
|
||||
"startLine": 294,
|
||||
"startChar": 3,
|
||||
"endLine": 294,
|
||||
"endChar": 32
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_268f18ce",
|
||||
@ -379,6 +488,138 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_6db263e7",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 299,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "can we clarify here as to where will this output be produced and stored? \nIs the expectation that this command generates the image and other info and pushes it back to git repo and later used by airshipctl?",
|
||||
"range": {
|
||||
"startLine": 299,
|
||||
"startChar": 23,
|
||||
"endLine": 299,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_2d0a2b25",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 307,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "can we describe the steps at a high level to what it means bootstrapping the host? what should be the output of this bootstrapping? A single node kubernetes cluster + \u003c\u003e ??",
|
||||
"range": {
|
||||
"startLine": 307,
|
||||
"startChar": 3,
|
||||
"endLine": 307,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_93633642",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 310,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "This statement seems to be unclear.",
|
||||
"range": {
|
||||
"startLine": 310,
|
||||
"startChar": 81,
|
||||
"endLine": 310,
|
||||
"endChar": 117
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_36d91882",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 312,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "In this case I think we are using an existing bootstrap cluster? If yes then we need to provide the `kubeconfig`.\n\nNot sure if you would like to mention this here.",
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_76f3100a",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 317,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t see this as a valid argument - https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/cmd/create_cluster.go",
|
||||
"range": {
|
||||
"startLine": 316,
|
||||
"startChar": 0,
|
||||
"endLine": 317,
|
||||
"endChar": 32
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_3647d81f",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 322,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T20:15:54Z",
|
||||
"side": 1,
|
||||
"message": "Please provide a link to the official repo.",
|
||||
"range": {
|
||||
"startLine": 322,
|
||||
"startChar": 100,
|
||||
"endLine": 322,
|
||||
"endChar": 105
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_7552813d",
|
||||
|
||||
Loading…
Reference in New Issue
Block a user