Update patch set 5
Patch Set 5: Code-Review-1 (13 comments) This is coming along really nicely! Looking forward to seeing this develop. Patch-set: 5 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 28618
Gerrit Code Review
parent
7280505d3b
commit
c589da61c0
279
d6b345748749982c6ed0da17faa83bab6766ad6b
Normal file
279
d6b345748749982c6ed0da17faa83bab6766ad6b
Normal file
@ -0,0 +1,279 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_dff5f1cc",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "trailing whitespace",
|
||||
"range": {
|
||||
"startLine": 22,
|
||||
"startChar": 128,
|
||||
"endLine": 22,
|
||||
"endChar": 129
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_3f2e8d43",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "Bullets should be indented two spaces.",
|
||||
"range": {
|
||||
"startLine": 28,
|
||||
"startChar": 0,
|
||||
"endLine": 28,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_3fd3ed3a",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "What does this mean? Are we able to say Shipyard will not be included in airshipctl and Airship 2.0?",
|
||||
"range": {
|
||||
"startLine": 46,
|
||||
"startChar": 13,
|
||||
"endLine": 46,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_9fed39f1",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "extra line",
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_3fbc4ddb",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 76,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "Should be a blank line after section headers",
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_1fb069f4",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "wrapping",
|
||||
"range": {
|
||||
"startLine": 86,
|
||||
"startChar": 0,
|
||||
"endLine": 86,
|
||||
"endChar": 150
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_9f9bf970",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "extra line break",
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_1f894922",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 90,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "Space required after this header",
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_ffb1d5e2",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 114,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "airship config",
|
||||
"range": {
|
||||
"startLine": 114,
|
||||
"startChar": 26,
|
||||
"endLine": 114,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_9fc21933",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 130,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "comma required here",
|
||||
"range": {
|
||||
"startLine": 130,
|
||||
"startChar": 5,
|
||||
"endLine": 130,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_bf6cbd36",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 245,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "Is there a benefit to being able to override the site (or context) in a single command? Seems like it could be handy for development/debugging purposes.",
|
||||
"range": {
|
||||
"startLine": 243,
|
||||
"startChar": 5,
|
||||
"endLine": 245,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_1f614937",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 424,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "trailing whitespace",
|
||||
"range": {
|
||||
"startLine": 424,
|
||||
"startChar": 130,
|
||||
"endLine": 424,
|
||||
"endChar": 131
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bfb3d3c7_bf559d52",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 426,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-05-20T21:34:48Z",
|
||||
"side": 1,
|
||||
"message": "workflow",
|
||||
"range": {
|
||||
"startLine": 426,
|
||||
"startChar": 15,
|
||||
"endLine": 426,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "d6b345748749982c6ed0da17faa83bab6766ad6b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue
Block a user