airship
/
specs
Code Issues Proposed changes

Update patch set 14 

Patch Set 14: Code-Review-1

(19 comments)

Patch-set: 14
Reviewer: Gerrit User 29624 <29624@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 29624 2019-07-02 12:50:24 +00:00 committed by Gerrit Code Review
parent d3af8ad2f4
commit d778239919
1 changed files with 441 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

441
40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e Normal file
View File

@ -0,0 +1,441 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_8550c333",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 46,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "Capitalization?",
"range": {
"startLine": 46,
"startChar": 53,
"endLine": 46,
"endChar": 62
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_25b5577e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 49,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 49,
"startChar": 83,
"endLine": 49,
"endChar": 84
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_40571902",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 109,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "capitalization on usage descriptions in table below",
"range": {
"startLine": 109,
"startChar": 0,
"endLine": 109,
"endChar": 19
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_e5609f03",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 115,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "lists",
"range": {
"startLine": 115,
"startChar": 33,
"endLine": 115,
"endChar": 37
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_604edd6f",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 117,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "inconsistent spacing from help usage above",
"range": {
"startLine": 117,
"startChar": 25,
"endLine": 117,
"endChar": 26
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_45b88b73",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 128,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 128,
"startChar": 107,
"endLine": 128,
"endChar": 108
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_65326f12",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 152,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "something",
"range": {
"startLine": 152,
"startChar": 53,
"endLine": 152,
"endChar": 62
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_e525ffc2",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 298,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "the ephemeral",
"range": {
"startLine": 298,
"startChar": 22,
"endLine": 298,
"endChar": 35
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_e06acdb0",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 312,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "extra whitespace",
"range": {
"startLine": 312,
"startChar": 20,
"endLine": 312,
"endChar": 21
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_851e836d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 358,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "bootstrapped",
"range": {
"startLine": 358,
"startChar": 7,
"endLine": 358,
"endChar": 20
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c5a31b42",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 360,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 360,
"startChar": 0,
"endLine": 360,
"endChar": 1
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6564af22",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 363,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 363,
"startChar": 118,
"endLine": 363,
"endChar": 119
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_206d45cb",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 403,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "inconsistent spacing in below table\u0027s usage descriptions (most of document has 1 space, these have 2)",
"range": {
"startLine": 403,
"startChar": 0,
"endLine": 403,
"endChar": 11
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c5ff9bff",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 453,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "extra whitespace",
"range": {
"startLine": 453,
"startChar": 58,
"endLine": 453,
"endChar": 59
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_456deb00",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 484,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 484,
"startChar": 111,
"endLine": 484,
"endChar": 112
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c578fbc1",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 486,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 486,
"startChar": 106,
"endLine": 486,
"endChar": 107
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_000fe12d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 532,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "extra whitespace",
"range": {
"startLine": 532,
"startChar": 24,
"endLine": 532,
"endChar": 25
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_654d8f98",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 574,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 574,
"startChar": 92,
"endLine": 574,
"endChar": 93
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_40095928",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 597,
"author": {
"id": 29624
},
"writtenOn": "2019-07-02T12:50:24Z",
"side": 1,
"message": "missing capitalization on several usage descriptions in table below",
"range": {
"startLine": 597,
"startChar": 0,
"endLine": 597,
"endChar": 20
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}