From dfad7b5ced81ecc168db84afba529be379704c3b Mon Sep 17 00:00:00 2001 From: Gerrit User 30260 <30260@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 12 Jun 2019 16:57:48 +0000 Subject: [PATCH] Update patch set 13 Patch Set 13: (4 comments) Will continue to review and provide more comments and feedback Patch-set: 13 Label: Verified=0 --- 0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a | 90 ++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a diff --git a/0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a b/0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a new file mode 100644 index 0000000..e3b7ba3 --- /dev/null +++ b/0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a @@ -0,0 +1,90 @@ +{ + "comments": [ + { + "key": { + "uuid": "9fb8cfa7_28d56744", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 13 + }, + "lineNbr": 47, + "author": { + "id": 30260 + }, + "writtenOn": "2019-06-12T16:57:48Z", + "side": 1, + "message": "it is not clear what will happen to Shipyard. will it be replaced by *airshipctl* as a plugin towards argo workflows or part of the native command structure? \nisn\u0027t Drydock impacted? Is it worth mentioning all impacted Airship 1.0 components or is it out of scope for the spec document?", + "range": { + "startLine": 47, + "startChar": 48, + "endLine": 47, + "endChar": 54 + }, + "revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "9fb8cfa7_73d91020", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 13 + }, + "lineNbr": 135, + "author": { + "id": 30260 + }, + "writtenOn": "2019-06-12T16:57:48Z", + "side": 1, + "message": "lower case \u0027a\u0027", + "range": { + "startLine": 135, + "startChar": 1, + "endLine": 135, + "endChar": 2 + }, + "revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "9fb8cfa7_d3f79c8a", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 13 + }, + "lineNbr": 139, + "author": { + "id": 30260 + }, + "writtenOn": "2019-06-12T16:57:48Z", + "side": 1, + "message": "This statement is redundant to the one made in line 135 or should be merged to deliver a single message", + "revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "9fb8cfa7_d3255c0a", + "filename": "specs/approved/airshipctl.rst", + "patchSetId": 13 + }, + "lineNbr": 141, + "author": { + "id": 30260 + }, + "writtenOn": "2019-06-12T16:57:48Z", + "side": 1, + "message": "This statement makes sense after the explanation of how the flag is set.", + "range": { + "startLine": 141, + "startChar": 0, + "endLine": 141, + "endChar": 59 + }, + "revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file