{ "comments": [ { "key": { "uuid": "9fb8cfa7_49196177", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 34, "author": { "id": 22477 }, "writtenOn": "2019-06-03T23:31:38Z", "side": 1, "message": "Asterisks are getting rendered as asterisks instead of italics. I think we just need asterisks or backticks.", "range": { "startLine": 34, "startChar": 19, "endLine": 34, "endChar": 20 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_6952b7e0", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 34, "author": { "id": 27046 }, "writtenOn": "2019-06-10T15:28:54Z", "side": 1, "message": "Done", "parentUuid": "9fb8cfa7_49196177", "range": { "startLine": 34, "startChar": 19, "endLine": 34, "endChar": 20 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_958e7e76", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 114, "author": { "id": 18675 }, "writtenOn": "2019-06-04T14:29:05Z", "side": 1, "message": "Would it not be better to allow plugins to have different versions. If these are go modules, would help if they can be versioned independent of the main airshipctl.", "range": { "startLine": 114, "startChar": 42, "endLine": 114, "endChar": 53 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_6c7405ff", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 114, "author": { "id": 27046 }, "writtenOn": "2019-06-10T15:28:54Z", "side": 1, "message": "I think you are correct, they will have different versions\nBut I think that should be a different command . Version command should be the airshipctl version. But a command that list the plugins and or modules, with version if ppropriate probable makes sense here. Will add that", "parentUuid": "9fb8cfa7_958e7e76", "range": { "startLine": 114, "startChar": 42, "endLine": 114, "endChar": 53 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_498e4179", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 118, "author": { "id": 22477 }, "writtenOn": "2019-06-03T23:31:38Z", "side": 1, "message": "Will config handling (both the airship-specific stuff and the stuff that gets delegated to kubectl client/cli) be handled by a plugin, or by the cli project itself? Might be a good thing to call out explicitly.", "range": { "startLine": 118, "startChar": 0, "endLine": 118, "endChar": 6 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_f220c74a", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 118, "author": { "id": 27046 }, "writtenOn": "2019-06-10T20:18:49Z", "side": 1, "message": "Done", "parentUuid": "9fb8cfa7_498e4179", "range": { "startLine": 118, "startChar": 0, "endLine": 118, "endChar": 6 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_893d19bd", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 127, "author": { "id": 22477 }, "writtenOn": "2019-06-03T23:31:38Z", "side": 1, "message": "I think we can get rid of the asterisks in all the examples", "range": { "startLine": 127, "startChar": 2, "endLine": 127, "endChar": 3 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_92194b23", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 127, "author": { "id": 27046 }, "writtenOn": "2019-06-10T20:18:49Z", "side": 1, "message": "Done", "parentUuid": "9fb8cfa7_893d19bd", "range": { "startLine": 127, "startChar": 2, "endLine": 127, "endChar": 3 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_69aea5e8", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 136, "author": { "id": 22477 }, "writtenOn": "2019-06-03T23:31:38Z", "side": 1, "message": "These backticks are rendering as a single long dash; to avoid confusion maybe we should put these in backticks (which will preserve --) or otherwise escape them", "range": { "startLine": 136, "startChar": 5, "endLine": 136, "endChar": 7 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_52d5131b", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 136, "author": { "id": 27046 }, "writtenOn": "2019-06-10T20:18:49Z", "side": 1, "message": "Done", "parentUuid": "9fb8cfa7_69aea5e8", "range": { "startLine": 136, "startChar": 5, "endLine": 136, "endChar": 7 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_e9837555", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 161, "author": { "id": 22477 }, "writtenOn": "2019-06-03T23:31:38Z", "side": 1, "message": "These are also rendering as a single long dash", "range": { "startLine": 161, "startChar": 67, "endLine": 161, "endChar": 69 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_92ee2beb", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 161, "author": { "id": 27046 }, "writtenOn": "2019-06-10T20:18:49Z", "side": 1, "message": "Done", "parentUuid": "9fb8cfa7_e9837555", "range": { "startLine": 161, "startChar": 67, "endLine": 161, "endChar": 69 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_55d7a64c", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 187, "author": { "id": 18675 }, "writtenOn": "2019-06-04T14:29:05Z", "side": 1, "message": "will future releases allow for short names such as ctx?", "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_2c64cd49", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 187, "author": { "id": 27046 }, "writtenOn": "2019-06-10T15:28:54Z", "side": 1, "message": "Need to decide if we want short names or not, other reviewers are against it.", "parentUuid": "9fb8cfa7_55d7a64c", "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_d5f5d6cc", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 225, "author": { "id": 18675 }, "writtenOn": "2019-06-04T14:29:05Z", "side": 1, "message": "Do we need a command to test if all the yaml docs are valid \n like airshictl config validate or is the assumption that the validation happens outside of airshipctl?", "range": { "startLine": 225, "startChar": 0, "endLine": 225, "endChar": 9 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9fb8cfa7_ecceb52b", "filename": "specs/approved/airshipctl.rst", "patchSetId": 12 }, "lineNbr": 225, "author": { "id": 27046 }, "writtenOn": "2019-06-10T15:28:54Z", "side": 1, "message": "We have that I think in the document plugin right. I don\u0027t expect to do yaml document stuff within the bootstrap command. Take a peek at the document section and let me know if you still think the validation you have in mind is missing", "parentUuid": "9fb8cfa7_d5f5d6cc", "range": { "startLine": 225, "startChar": 0, "endLine": 225, "endChar": 9 }, "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false } ] }