1f5148fc3a
Patch Set 5: Code-Review-1 (3 comments) Patch-set: 5 Label: Code-Review=-1
176 lines
4.7 KiB
Plaintext
176 lines
4.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_01cdf583",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 50,
|
|
"author": {
|
|
"id": 22259
|
|
},
|
|
"writtenOn": "2019-06-26T20:54:44Z",
|
|
"side": 1,
|
|
"message": "logs?",
|
|
"range": {
|
|
"startLine": 50,
|
|
"startChar": 14,
|
|
"endLine": 50,
|
|
"endChar": 21
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_a1c5095e",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 50,
|
|
"author": {
|
|
"id": 22259
|
|
},
|
|
"writtenOn": "2019-06-26T20:54:44Z",
|
|
"side": 1,
|
|
"message": "chart name?",
|
|
"range": {
|
|
"startLine": 50,
|
|
"startChar": 36,
|
|
"endLine": 50,
|
|
"endChar": 41
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_c1c27d53",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 22259
|
|
},
|
|
"writtenOn": "2019-06-26T20:54:44Z",
|
|
"side": 1,
|
|
"message": "status?",
|
|
"range": {
|
|
"startLine": 51,
|
|
"startChar": 4,
|
|
"endLine": 51,
|
|
"endChar": 9
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_818fa528",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 56,
|
|
"author": {
|
|
"id": 22259
|
|
},
|
|
"writtenOn": "2019-06-26T20:54:44Z",
|
|
"side": 1,
|
|
"message": "extra space",
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_3dcdac84",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 56,
|
|
"author": {
|
|
"id": 20466
|
|
},
|
|
"writtenOn": "2019-06-27T12:40:40Z",
|
|
"side": 1,
|
|
"message": "duration",
|
|
"range": {
|
|
"startLine": 56,
|
|
"startChar": 25,
|
|
"endLine": 56,
|
|
"endChar": 32
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_c18b5dbd",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 22259
|
|
},
|
|
"writtenOn": "2019-06-26T20:54:44Z",
|
|
"side": 1,
|
|
"message": "I thought the main idea of the spec was to expose an endpoint within armada which could be scraped by prometheus and thus monitoring of these chart deployment etc. could be included in the LMA framework.\n\nI am not clear if we are achieving the same with the proposed solution or how would prometheus be able to scrape the time metrics with the proposed solution? can it be clarified?",
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_9dbcd8dc",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 116,
|
|
"author": {
|
|
"id": 20466
|
|
},
|
|
"writtenOn": "2019-06-27T12:40:40Z",
|
|
"side": 1,
|
|
"message": "nit: `` backtick",
|
|
"range": {
|
|
"startLine": 116,
|
|
"startChar": 0,
|
|
"endLine": 116,
|
|
"endChar": 30
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9fb8cfa7_1dd0e81e",
|
|
"filename": "specs/approved/armada_time_metrics.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 162,
|
|
"author": {
|
|
"id": 20466
|
|
},
|
|
"writtenOn": "2019-06-27T12:40:40Z",
|
|
"side": 1,
|
|
"message": "remove?",
|
|
"range": {
|
|
"startLine": 162,
|
|
"startChar": 0,
|
|
"endLine": 162,
|
|
"endChar": 4
|
|
},
|
|
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |