airship
/
specs
Code Issues Proposed changes
specs/4f45c2f23468b349a4185fb84ab...

228 lines
7.9 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "3f79a3b5_13de74da",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 50,
"author": {
"id": 26365
},
"writtenOn": "2018-10-15T17:36:12Z",
"side": 1,
"message": "during the document validation or at deployment runtime? If we can know this at the time of \"commit configdocs\", it would be a lot more obvious to the user that something configured is being ignored due to the current OOB driver. If we only warn at runtime, the info would likely not be seen by the end user.",
"range": {
"startLine": 50,
"startChar": 25,
"endLine": 50,
"endChar": 63
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f75cbd1b",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 50,
"author": {
"id": 10366
},
"writtenOn": "2018-10-18T07:36:47Z",
"side": 1,
"message": "Agreed, updated with your suggestions. This can be done by adding new validator in drydock.",
"parentUuid": "3f79a3b5_13de74da",
"range": {
"startLine": 50,
"startChar": 25,
"endLine": 50,
"endChar": 63
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_b6baa06e",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 57,
"author": {
"id": 28208
},
"writtenOn": "2018-09-26T09:28:10Z",
"side": 1,
"message": "I would rather use a multi-line string, containing a text ()json, xml) document with full BIOS configuration from hardware vendor. Yes, it will be vendor-dependent, and even more - hardware model dependent.\nIt would be a pain to support key/value pairs for multiple vendors, and it would be easy to set-up one BIOS of one server model, dump config, remove specific server details, and then apply this config onto every server of the same model.\nThen we would think of how to apply BIOS settings which are server-specific (e.g. node name) to each of the servers.",
"range": {
"startLine": 56,
"startChar": 59,
"endLine": 57,
"endChar": 56
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_3f0baed5",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 57,
"author": {
"id": 10366
},
"writtenOn": "2018-09-27T06:09:31Z",
"side": 1,
"message": "I would prefer key/value pair to keep the HardwareProfile document clean and able to modify parameters in a cleaner way programmatically. We can have separate hardware profile documents for different vendors and use deckhand substitutions for the common bios parameters if required.",
"parentUuid": "3f79a3b5_b6baa06e",
"range": {
"startLine": 56,
"startChar": 59,
"endLine": 57,
"endChar": 56
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_4ea92d8d",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 57,
"author": {
"id": 28208
},
"writtenOn": "2018-10-09T09:06:59Z",
"side": 1,
"message": "Well, it would be pain to maintain in deckhand.\nWhereas with multi-line string you could just copy-paste what vendor provides.",
"parentUuid": "3f79a3b5_3f0baed5",
"range": {
"startLine": 56,
"startChar": 59,
"endLine": 57,
"endChar": 56
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d79981cf",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 57,
"author": {
"id": 10366
},
"writtenOn": "2018-10-18T07:36:47Z",
"side": 1,
"message": "As per the discussion in Weekly meeting, will leave it as key/value pair.",
"parentUuid": "3f79a3b5_4ea92d8d",
"range": {
"startLine": 56,
"startChar": 59,
"endLine": 57,
"endChar": 56
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_7f16d1f3",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 122,
"author": {
"id": 7776
},
"writtenOn": "2018-08-10T17:38:23Z",
"side": 1,
"message": "Are these API calls authenticated? Does Drydock automatically know where to obtain the appropriate credentials for each OOB IP or does there need to be something in the YAML that tells Drydock where to retrieve the credentials from?",
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_df415a38",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 122,
"author": {
"id": 10366
},
"writtenOn": "2018-09-27T06:09:31Z",
"side": 1,
"message": "Yes the API calls are authenticated. Credentials can be provided in Site manifests of Drydock (to be specific, HostProfile) documents. Ex: https://github.com/openstack/airship-treasuremap/blob/3a1038e122349aa6599691a7e2c6bf167e93d744/global/profiles/host/cp.yaml",
"parentUuid": "3f79a3b5_7f16d1f3",
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f395f8e3",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 170,
"author": {
"id": 26365
},
"writtenOn": "2018-10-15T17:36:12Z",
"side": 1,
"message": "is there an intent to parallelize this across all the nodes being deployed, or are we stuck with sequential?",
"range": {
"startLine": 167,
"startChar": 0,
"endLine": 170,
"endChar": 64
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_17885969",
"filename": "specs/approved/drydock_support_bios_configuration.rst",
"patchSetId": 6
},
"lineNbr": 170,
"author": {
"id": 10366
},
"writtenOn": "2018-10-18T07:36:47Z",
"side": 1,
"message": "Current implementation already supports execution of subtasks of driver actions in parallel upto maximum of 16 workers. So maximum of 16 nodes will be configured in parallel.",
"parentUuid": "3f79a3b5_f395f8e3",
"range": {
"startLine": 167,
"startChar": 0,
"endLine": 170,
"endChar": 64
},
"revId": "4f45c2f23468b349a4185fb84ab640b32742d279",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink