250 lines
8.2 KiB
Plaintext
250 lines
8.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_5a6155d3",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "This will require feature warnings for the IPMI driver that it cannot implement some settings described in the site definition.",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_01427b0d",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "Yes there should be warnings for rest of OOB drivers",
|
|
"parentUuid": "5f7c97a3_5a6155d3",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_42207e4b",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 28803
|
|
},
|
|
"writtenOn": "2018-08-03T17:10:37Z",
|
|
"side": 1,
|
|
"message": "shouldnt the warning be in the drydock framework, since we may have many drivers each with its subset of functionality, in driver init() we may have to check the methods supported and warn -- will add a storyboard item if you all agree",
|
|
"parentUuid": "5f7c97a3_5a6155d3",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_375cb44a",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 110,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t believe this is part of json-schema, the field would just not appear in the required properties list.",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_615c8fef",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 110,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "Removed optional field.",
|
|
"parentUuid": "5f7c97a3_375cb44a",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_5a0ab51d",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "I\u0027m not sure this is needed as the verify step should generally be use to verify things that the deployment isn\u0027t going to fix/change. To verify settings that will be corrected during deployment is not needed.",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_4155d3bf",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "Removed the VerifyBiosConfig",
|
|
"parentUuid": "5f7c97a3_5a0ab51d",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_02c28686",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 28803
|
|
},
|
|
"writtenOn": "2018-08-03T17:10:37Z",
|
|
"side": 1,
|
|
"message": "thought here is to define a way to validate the bios-settings, this may not be directly in airflow DAGs, a forward looking usecase is an external tool to which validates whole setup, more like a read-only of ConfigBios()",
|
|
"parentUuid": "5f7c97a3_5a0ab51d",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_1a299d81",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 141,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "Will this be auto-detected by the driver or will it use the HardwareProfile to decide behavior?",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_210777ca",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 141,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "This will be auto-detected by the driver using Redfish API for Manager.",
|
|
"parentUuid": "5f7c97a3_1a299d81",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_7a4f7168",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "Again, this may not be needed.",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_01f03bd9",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5f7c97a3_7a4f7168",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_7a68d1ba",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 178,
|
|
"author": {
|
|
"id": 26449
|
|
},
|
|
"writtenOn": "2018-08-01T12:44:57Z",
|
|
"side": 1,
|
|
"message": "If there has been a trial, it would be good to include an order of magnitude estimate of how long the ConfigBios step will take for each node.",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_01191b21",
|
|
"filename": "specs/approved/drydock_support_bios_configuration.rst",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 178,
|
|
"author": {
|
|
"id": 10366
|
|
},
|
|
"writtenOn": "2018-08-02T10:24:57Z",
|
|
"side": 1,
|
|
"message": "Updated with the time taken on average for bios configuration retrieval/update. Do you have any stats from IPMI driver, will be helpful to see how those fare with redfish driver.",
|
|
"parentUuid": "5f7c97a3_7a68d1ba",
|
|
"revId": "b8b3e25c4a81b3b5684669c02892a7ef7a1c0eae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |