airship/specs
Code Issues Proposed changes
46870c8e99
specs/0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a
Gerrit User 28869 7a83fdbf8f Update patch set 13 
Patch Set 13: Code-Review-1

(8 comments)

Patch-set: 13
Label: Code-Review=-1
2019-06-25 21:21:35 +00:00

475 lines
13 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_55909d43",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 11,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "unneeded white space",
"range": {
"startLine": 11,
"startChar": 7,
"endLine": 11,
"endChar": 8
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_28d56744",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 47,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "it is not clear what will happen to Shipyard. will it be replaced by *airshipctl* as a plugin towards argo workflows or part of the native command structure? \nisn\u0027t Drydock impacted? Is it worth mentioning all impacted Airship 1.0 components or is it out of scope for the spec document?",
"range": {
"startLine": 47,
"startChar": 48,
"endLine": 47,
"endChar": 54
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f53c3130",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 113,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "extra characters",
"range": {
"startLine": 113,
"startChar": 58,
"endLine": 113,
"endChar": 60
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_951e15b9",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 115,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "I don\u0027t think this option makes sense. If a user wants to know which plugins are available, he would simply run `airshipctl help`",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d556cd5c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 125,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "This may ready better as:\n\nA YAML configuration file describes location, ...",
"range": {
"startLine": 125,
"startChar": 0,
"endLine": 125,
"endChar": 45
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b549d9b7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "implies",
"range": {
"startLine": 126,
"startChar": 87,
"endLine": 126,
"endChar": 95
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b51b19c8",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 126,
"startChar": 106,
"endLine": 126,
"endChar": 107
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f5d8b1ef",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "*airshipctl*",
"range": {
"startLine": 126,
"startChar": 69,
"endLine": 126,
"endChar": 79
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3d4967b6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 130,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "this should be `set-context`.",
"range": {
"startLine": 130,
"startChar": 20,
"endLine": 130,
"endChar": 39
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_73d91020",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 135,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "lower case \u0027a\u0027",
"range": {
"startLine": 135,
"startChar": 1,
"endLine": 135,
"endChar": 2
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3f79c8a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 139,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement is redundant to the one made in line 135 or should be merged to deliver a single message",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3255c0a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 141,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement makes sense after the explanation of how the flag is set.",
"range": {
"startLine": 141,
"startChar": 0,
"endLine": 141,
"endChar": 59
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_bd15574b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 171,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "is there a special need for this command? we should be able to set the current context using `set-context my-context`",
"range": {
"startLine": 171,
"startChar": 25,
"endLine": 171,
"endChar": 42
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6baf19e3",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 249,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "can remove this",
"range": {
"startLine": 249,
"startChar": 26,
"endLine": 249,
"endChar": 33
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_264cf8c6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 277,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 277,
"startChar": 10,
"endLine": 277,
"endChar": 16
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_268f18ce",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 51,
"endLine": 297,
"endChar": 56
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c6a07c45",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 23,
"endLine": 297,
"endChar": 30
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_7552813d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 376,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "Unique",
"range": {
"startLine": 376,
"startChar": 3,
"endLine": 376,
"endChar": 10
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_634e5d39",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 407,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:21:11Z",
"side": 1,
"message": "the generate and rotate commands seem redundant. currently generate passphrases generates passphrases in the security repo for that site. then push/merge in gerrit.\n\nrotate passphrases is essentially the same thing, delete existing passphrases in security repo for that site, generate passphrases, push/merge in gerrit.\n\nditto for the certs via pki command",
"range": {
"startLine": 399,
"startChar": 0,
"endLine": 407,
"endChar": 79
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_0338c19d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 432,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:17:36Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 432,
"startChar": 53,
"endLine": 432,
"endChar": 54
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_63b97d13",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 581,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:17:36Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 581,
"startChar": 0,
"endLine": 581,
"endChar": 2
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink