airship/specs
Code Issues Proposed changes
56d3ce369d
specs/0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a
Gerrit User 22259 682eb0e322 Update patch set 13 
Patch Set 13:

(8 comments)

Patch-set: 13
2019-07-01 22:19:36 +00:00

894 lines
26 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_55909d43",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 11,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "unneeded white space",
"range": {
"startLine": 11,
"startChar": 7,
"endLine": 11,
"endChar": 8
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_28d56744",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 47,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "it is not clear what will happen to Shipyard. will it be replaced by *airshipctl* as a plugin towards argo workflows or part of the native command structure? \nisn\u0027t Drydock impacted? Is it worth mentioning all impacted Airship 1.0 components or is it out of scope for the spec document?",
"range": {
"startLine": 47,
"startChar": 48,
"endLine": 47,
"endChar": 54
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f53c3130",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 113,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "extra characters",
"range": {
"startLine": 113,
"startChar": 58,
"endLine": 113,
"endChar": 60
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_951e15b9",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 115,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "I don\u0027t think this option makes sense. If a user wants to know which plugins are available, he would simply run `airshipctl help`",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f27af521",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 119,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "does it make sense to define a generic schema or a layout example of how the config will look like as part of this spec?",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d556cd5c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 125,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "This may ready better as:\n\nA YAML configuration file describes location, ...",
"range": {
"startLine": 125,
"startChar": 0,
"endLine": 125,
"endChar": 45
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b549d9b7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "implies",
"range": {
"startLine": 126,
"startChar": 87,
"endLine": 126,
"endChar": 95
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b51b19c8",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 126,
"startChar": 106,
"endLine": 126,
"endChar": 107
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f5d8b1ef",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "*airshipctl*",
"range": {
"startLine": 126,
"startChar": 69,
"endLine": 126,
"endChar": 79
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3d4967b6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 130,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "this should be `set-context`.",
"range": {
"startLine": 130,
"startChar": 20,
"endLine": 130,
"endChar": 39
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_73d91020",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 135,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "lower case \u0027a\u0027",
"range": {
"startLine": 135,
"startChar": 1,
"endLine": 135,
"endChar": 2
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3f79c8a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 139,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement is redundant to the one made in line 135 or should be merged to deliver a single message",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3255c0a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 141,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement makes sense after the explanation of how the flag is set.",
"range": {
"startLine": 141,
"startChar": 0,
"endLine": 141,
"endChar": 59
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_bd15574b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 171,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "is there a special need for this command? we should be able to set the current context using `set-context my-context`",
"range": {
"startLine": 171,
"startChar": 25,
"endLine": 171,
"endChar": 42
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_56da8c4a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 238,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "Is this independent of cluster-api concept of creating the bootstrap cluster or there are plans to leverage bootstrap mechanism via clusterctl calls? - https://github.com/kubernetes-sigs/cluster-api/tree/master/cmd/clusterctl#creating-a-cluster",
"range": {
"startLine": 238,
"startChar": 0,
"endLine": 238,
"endChar": 31
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f5cdff5c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 247,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "This can be represented as a codeblock syntax \"::\"",
"range": {
"startLine": 245,
"startChar": 8,
"endLine": 247,
"endChar": 35
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6baf19e3",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 249,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "can remove this",
"range": {
"startLine": 249,
"startChar": 26,
"endLine": 249,
"endChar": 33
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_264cf8c6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 277,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 277,
"startChar": 10,
"endLine": 277,
"endChar": 16
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_89146c4e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 290,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "How do we ensure that these are the only set of CR\u0027s that get delivered to the bootstrap cluster as in the config we are pointing to the complete site repository which would contain all the documents for a site. \n\nShould there be a different ``config set-repository`` for different phases in the deployment? for eg: prior to running ``bootstrap init`` we need to set config or clone documents only related to bootstrap? If yes then it can be clarified in the spec.",
"range": {
"startLine": 283,
"startChar": 0,
"endLine": 290,
"endChar": 6
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_cd9b4f70",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 294,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "- Where would this yaml definition live? \n- how will ``airshipctl`` know to use this yaml definition as part of this command? do we pass the yaml definition as a flag, whether it reads from the config file?\n- what would be the contents of the yaml definiton? can we have example layout or schema at a high level with the contents of this file as part of the spec.",
"range": {
"startLine": 294,
"startChar": 3,
"endLine": 294,
"endChar": 32
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_268f18ce",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 51,
"endLine": 297,
"endChar": 56
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c6a07c45",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 23,
"endLine": 297,
"endChar": 30
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6db263e7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 299,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "can we clarify here as to where will this output be produced and stored? \nIs the expectation that this command generates the image and other info and pushes it back to git repo and later used by airshipctl?",
"range": {
"startLine": 299,
"startChar": 23,
"endLine": 299,
"endChar": 44
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_2d0a2b25",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 307,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "can we describe the steps at a high level to what it means bootstrapping the host? what should be the output of this bootstrapping? A single node kubernetes cluster + \u003c\u003e ??",
"range": {
"startLine": 307,
"startChar": 3,
"endLine": 307,
"endChar": 21
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_93633642",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 310,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "This statement seems to be unclear.",
"range": {
"startLine": 310,
"startChar": 81,
"endLine": 310,
"endChar": 117
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_36d91882",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 312,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "In this case I think we are using an existing bootstrap cluster? If yes then we need to provide the `kubeconfig`.\n\nNot sure if you would like to mention this here.",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_76f3100a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 317,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "I don\u0027t see this as a valid argument - https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/cmd/create_cluster.go",
"range": {
"startLine": 316,
"startChar": 0,
"endLine": 317,
"endChar": 32
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3647d81f",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 322,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T20:15:54Z",
"side": 1,
"message": "Please provide a link to the official repo.",
"range": {
"startLine": 322,
"startChar": 100,
"endLine": 322,
"endChar": 105
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c1f0f893",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 368,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "Airship",
"range": {
"startLine": 368,
"startChar": 4,
"endLine": 368,
"endChar": 11
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_7552813d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 376,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "Unique",
"range": {
"startLine": 376,
"startChar": 3,
"endLine": 376,
"endChar": 10
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_2124740c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 378,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "I am assumming the below options mentioned are meant to be running against a live cluster? Please correct my understanding.\nIf yes then do we want to have an option here to `generate` the bundle for a given `site` similar to `pegleg collect`.\n\nWill the document lifecycle look like below?:\n- generate bundle\n- push the bundle to the site as a secret i.e. ``document \n apply``\n- armada or whatever tool will reference this secret as part of argo workflow to then create these resources ie. ``armada apply`` or similar to ``armada_build``\n\nAlso we can do multiple ``apply`` of this bundle, do we intend to store versions for this bundle?",
"range": {
"startLine": 378,
"startChar": 0,
"endLine": 378,
"endChar": 18
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_41964840",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 387,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "- what does `specific manifest` mean here?",
"range": {
"startLine": 387,
"startChar": 36,
"endLine": 387,
"endChar": 77
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_634e5d39",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 407,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:21:11Z",
"side": 1,
"message": "the generate and rotate commands seem redundant. currently generate passphrases generates passphrases in the security repo for that site. then push/merge in gerrit.\n\nrotate passphrases is essentially the same thing, delete existing passphrases in security repo for that site, generate passphrases, push/merge in gerrit.\n\nditto for the certs via pki command",
"range": {
"startLine": 399,
"startChar": 0,
"endLine": 407,
"endChar": 79
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c156b82a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 430,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "is this somewhat similar to a cookiecutter creating a basic template for users who want to create their own site documents from scratch?\nAfter looking at the statement in L437, it maybe useful for this command to take flags so that if user wants to just give a try to Airship then they can clone a working stable type from treasuremap and be good to go or if they want to build from scratch they use the flag to create a basic template",
"range": {
"startLine": 430,
"startChar": 5,
"endLine": 430,
"endChar": 35
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_0338c19d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 432,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:17:36Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 432,
"startChar": 53,
"endLine": 432,
"endChar": 54
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1c38b3d0",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 508,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 508,
"startChar": 115,
"endLine": 508,
"endChar": 124
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_dcb0db42",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 540,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "what would these specific preparation task would be that cannot be achieved via making manifest changes to BMH and Machine spec and let the cluster API machine controller drive the redeployment as part of `sitemanage update_site` WF",
"range": {
"startLine": 539,
"startChar": 85,
"endLine": 540,
"endChar": 118
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9c882371",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 554,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "Duplicated",
"range": {
"startLine": 552,
"startChar": 0,
"endLine": 554,
"endChar": 65
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_63b97d13",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 581,
"author": {
"id": 29624
},
"writtenOn": "2019-06-25T02:17:36Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 581,
"startChar": 0,
"endLine": 581,
"endChar": 2
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_fc983fc0",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 593,
"author": {
"id": 22259
},
"writtenOn": "2019-07-01T22:19:36Z",
"side": 1,
"message": "This section can be utilized to include all the reference link used in the document similar to other specs.",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink